Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add platform_identifier to r/aws_sagemaker_notebook_instance #20711

Merged
merged 5 commits into from
Aug 30, 2021
Merged

feat: add platform_identifier to r/aws_sagemaker_notebook_instance #20711

merged 5 commits into from
Aug 30, 2021

Conversation

lastlee
Copy link
Contributor

@lastlee lastlee commented Aug 27, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #20706

Release notes for CHANGELOG:

resource_aws_sagemaker_notebook_instance - add `platform_identifier` parameter

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_basic -timeout 180m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (482.86s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       482.954s

$ make testacc TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_platform_identifier'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_platform_identifier -timeout 180m
=== RUN   TestAccAWSSagemakerNotebookInstance_platform_identifier
=== PAUSE TestAccAWSSagemakerNotebookInstance_platform_identifier
=== CONT  TestAccAWSSagemakerNotebookInstance_platform_identifier
--- PASS: TestAccAWSSagemakerNotebookInstance_platform_identifier (882.85s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       882.949s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Aug 27, 2021
github-actions[bot]
github-actions bot reviewed Aug 27, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @lastlee 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Aug 27, 2021
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 27, 2021
ewbankkit
ewbankkit approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_ -timeout 180m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_volumesize
=== PAUSE TestAccAWSSagemakerNotebookInstance_volumesize
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_kms
=== PAUSE TestAccAWSSagemakerNotebookInstance_kms
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== RUN   TestAccAWSSagemakerNotebookInstance_platform_identifier
=== PAUSE TestAccAWSSagemakerNotebookInstance_platform_identifier
=== RUN   TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== RUN   TestAccAWSSagemakerNotebookInstance_default_code_repository
=== PAUSE TestAccAWSSagemakerNotebookInstance_default_code_repository
=== RUN   TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== PAUSE TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== RUN   TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo
=== PAUSE TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
=== CONT  TestAccAWSSagemakerNotebookInstance_update
=== CONT  TestAccAWSSagemakerNotebookInstance_volumesize
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_kms
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== CONT  TestAccAWSSagemakerNotebookInstance_platform_identifier
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (387.20s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (495.99s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (496.53s)
--- PASS: TestAccAWSSagemakerNotebookInstance_kms (634.43s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (783.53s)
--- PASS: TestAccAWSSagemakerNotebookInstance_platform_identifier (787.76s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (897.27s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (900.83s)
--- PASS: TestAccAWSSagemakerNotebookInstance_volumesize (1148.06s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (1220.92s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository (1293.89s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo (1417.04s)
--- PASS: TestAccAWSSagemakerNotebookInstance_additional_code_repositories (1480.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1484.716s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_ -timeout 180m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_volumesize
=== PAUSE TestAccAWSSagemakerNotebookInstance_volumesize
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_kms
=== PAUSE TestAccAWSSagemakerNotebookInstance_kms
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== RUN   TestAccAWSSagemakerNotebookInstance_platform_identifier
=== PAUSE TestAccAWSSagemakerNotebookInstance_platform_identifier
=== RUN   TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== RUN   TestAccAWSSagemakerNotebookInstance_default_code_repository
=== PAUSE TestAccAWSSagemakerNotebookInstance_default_code_repository
=== RUN   TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== PAUSE TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== RUN   TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo
=== PAUSE TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
=== CONT  TestAccAWSSagemakerNotebookInstance_kms
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_platform_identifier
=== CONT  TestAccAWSSagemakerNotebookInstance_volumesize
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== CONT  TestAccAWSSagemakerNotebookInstance_update
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker code repository: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 53207e2e-49fd-4e11-82b1-05226c1f6bc5
        
          with aws_sagemaker_code_repository.test,
          on terraform_plugin_test.tf line 19, in resource "aws_sagemaker_code_repository" "test":
          19: resource "aws_sagemaker_code_repository" "test" {
        
--- SKIP: TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo (18.88s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (366.27s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (383.85s)
--- PASS: TestAccAWSSagemakerNotebookInstance_kms (413.93s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (472.90s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (721.46s)
--- PASS: TestAccAWSSagemakerNotebookInstance_platform_identifier (745.53s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (852.93s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (889.58s)
--- PASS: TestAccAWSSagemakerNotebookInstance_volumesize (1049.22s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (1264.22s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository (1281.14s)
--- PASS: TestAccAWSSagemakerNotebookInstance_additional_code_repositories (1360.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1365.491s

@ewbankkit
Copy link
Contributor

@lastlee Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3360648 into hashicorp:main Aug 30, 2021
@github-actions github-actions bot added this to the v3.57.0 milestone Aug 30, 2021
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This functionality has been released in v3.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.57.0
Development

Successfully merging this pull request may close these issues.

Add platform_identifier support to r/aws_sagemaker_notebook_instance
4 participants
@lastlee @ewbankkit @breathingdust @davidmlee-okta