Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMPCA Add support for enabling OCSP #20946

Closed
fabio42 opened this issue Sep 17, 2021 · 3 comments · Fixed by #25720
Closed

ACMPCA Add support for enabling OCSP #20946

fabio42 opened this issue Sep 17, 2021 · 3 comments · Fixed by #25720
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/acmpca Issues and PRs that pertain to the acmpca service.
Milestone

Comments

@fabio42
Copy link

fabio42 commented Sep 17, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

As part of ACM Private CA, support for OCSP should be added in create resource.

New or Affected Resource(s)

  • aws_acmpca_certificate_authority

Potential Terraform Configuration

Under revocation_configuration, probably a new ocsp_configuration should be added with the following options:

resource "aws_acmpca_certificate_authority" "example" {
  certificate_authority_configuration {
    key_algorithm     = "RSA_4096"
    signing_algorithm = "SHA512WITHRSA"

    subject {
      common_name = "example.com"
    }
  }

  revocation_configuration {
    ocsp_configuration {
         custom_cname  = "ocsp.example.com"
         enabled = true
    }
  }
}

References

@fabio42 fabio42 added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 17, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/acmpca Issues and PRs that pertain to the acmpca service. labels Sep 17, 2021
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
@mattburgess
Copy link
Collaborator

I'll take this one; I have the resource side of this working, just need to fix up the datasource.

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/acmpca Issues and PRs that pertain to the acmpca service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants