Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_acmpca_certificate_authority: Add support for OCSP #25720

Merged
merged 5 commits into from
Jul 7, 2022
Merged

r/aws_acmpca_certificate_authority: Add support for OCSP #25720

merged 5 commits into from
Jul 7, 2022

Conversation

mattburgess
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20946

Output from acceptance testing:

$ make testacc TESTS=TestAccACMPCACertificateAuthority PKG=acmpca
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acmpca/... -v -count 1 -parallel 20 -run='TestAccACMPCACertificateAuthority'  -timeout 180m
=== RUN   TestAccACMPCACertificateAuthorityCertificate_rootCA
=== PAUSE TestAccACMPCACertificateAuthorityCertificate_rootCA
=== RUN   TestAccACMPCACertificateAuthorityCertificate_updateRootCA
=== PAUSE TestAccACMPCACertificateAuthorityCertificate_updateRootCA
=== RUN   TestAccACMPCACertificateAuthorityCertificate_subordinateCA
=== PAUSE TestAccACMPCACertificateAuthorityCertificate_subordinateCA
=== RUN   TestAccACMPCACertificateAuthorityDataSource_basic
=== PAUSE TestAccACMPCACertificateAuthorityDataSource_basic
=== RUN   TestAccACMPCACertificateAuthorityDataSource_s3ObjectACL
=== PAUSE TestAccACMPCACertificateAuthorityDataSource_s3ObjectACL
=== RUN   TestAccACMPCACertificateAuthority_basic
=== PAUSE TestAccACMPCACertificateAuthority_basic
=== RUN   TestAccACMPCACertificateAuthority_disappears
=== PAUSE TestAccACMPCACertificateAuthority_disappears
=== RUN   TestAccACMPCACertificateAuthority_enabledDeprecated
=== PAUSE TestAccACMPCACertificateAuthority_enabledDeprecated
=== RUN   TestAccACMPCACertificateAuthority_deleteFromActiveState
=== PAUSE TestAccACMPCACertificateAuthority_deleteFromActiveState
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_enabled
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_enabled
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_s3ObjectACL
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_s3ObjectACL
=== RUN   TestAccACMPCACertificateAuthority_RevocationOcsp_enabled
=== PAUSE TestAccACMPCACertificateAuthority_RevocationOcsp_enabled
=== RUN   TestAccACMPCACertificateAuthority_RevocationOcsp_customCNAME
=== PAUSE TestAccACMPCACertificateAuthority_RevocationOcsp_customCNAME
=== RUN   TestAccACMPCACertificateAuthority_tags
=== PAUSE TestAccACMPCACertificateAuthority_tags
=== CONT  TestAccACMPCACertificateAuthorityCertificate_rootCA
=== CONT  TestAccACMPCACertificateAuthority_deleteFromActiveState
=== CONT  TestAccACMPCACertificateAuthority_tags
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME
=== CONT  TestAccACMPCACertificateAuthorityCertificate_subordinateCA
=== CONT  TestAccACMPCACertificateAuthorityCertificate_updateRootCA
=== CONT  TestAccACMPCACertificateAuthorityDataSource_basic
=== CONT  TestAccACMPCACertificateAuthority_RevocationOcsp_customCNAME
=== CONT  TestAccACMPCACertificateAuthorityDataSource_s3ObjectACL
=== CONT  TestAccACMPCACertificateAuthority_disappears
=== CONT  TestAccACMPCACertificateAuthority_enabledDeprecated
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_s3ObjectACL
=== CONT  TestAccACMPCACertificateAuthority_basic
=== CONT  TestAccACMPCACertificateAuthority_RevocationOcsp_enabled
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_enabled
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays
--- PASS: TestAccACMPCACertificateAuthority_disappears (48.09s)
--- PASS: TestAccACMPCACertificateAuthorityDataSource_s3ObjectACL (62.70s)
--- PASS: TestAccACMPCACertificateAuthorityDataSource_basic (62.78s)
--- PASS: TestAccACMPCACertificateAuthority_deleteFromActiveState (66.92s)
--- PASS: TestAccACMPCACertificateAuthorityCertificate_subordinateCA (81.33s)
--- PASS: TestAccACMPCACertificateAuthorityCertificate_rootCA (81.50s)
--- PASS: TestAccACMPCACertificateAuthority_basic (82.43s)
--- PASS: TestAccACMPCACertificateAuthorityCertificate_updateRootCA (97.74s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_s3ObjectACL (101.29s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays (119.18s)
--- PASS: TestAccACMPCACertificateAuthority_enabledDeprecated (119.43s)
--- PASS: TestAccACMPCACertificateAuthority_tags (130.81s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationOcsp_enabled (134.15s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationOcsp_customCNAME (146.56s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_enabled (147.91s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME (162.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acmpca	162.165s

@github-actions github-actions bot added service/acmpca Issues and PRs that pertain to the acmpca service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. labels Jul 6, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jul 6, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 7, 2022
ewbankkit
ewbankkit approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccACMPCACertificateAuthority' PKG=acmpca ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acmpca/... -v -count 1 -parallel 2  -run=TestAccACMPCACertificateAuthority -timeout 180m
=== RUN   TestAccACMPCACertificateAuthorityCertificate_rootCA
=== PAUSE TestAccACMPCACertificateAuthorityCertificate_rootCA
=== RUN   TestAccACMPCACertificateAuthorityCertificate_updateRootCA
=== PAUSE TestAccACMPCACertificateAuthorityCertificate_updateRootCA
=== RUN   TestAccACMPCACertificateAuthorityCertificate_subordinateCA
=== PAUSE TestAccACMPCACertificateAuthorityCertificate_subordinateCA
=== RUN   TestAccACMPCACertificateAuthorityDataSource_basic
=== PAUSE TestAccACMPCACertificateAuthorityDataSource_basic
=== RUN   TestAccACMPCACertificateAuthorityDataSource_s3ObjectACL
=== PAUSE TestAccACMPCACertificateAuthorityDataSource_s3ObjectACL
=== RUN   TestAccACMPCACertificateAuthority_basic
=== PAUSE TestAccACMPCACertificateAuthority_basic
=== RUN   TestAccACMPCACertificateAuthority_disappears
=== PAUSE TestAccACMPCACertificateAuthority_disappears
=== RUN   TestAccACMPCACertificateAuthority_enabledDeprecated
=== PAUSE TestAccACMPCACertificateAuthority_enabledDeprecated
=== RUN   TestAccACMPCACertificateAuthority_deleteFromActiveState
=== PAUSE TestAccACMPCACertificateAuthority_deleteFromActiveState
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_enabled
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_enabled
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_s3ObjectACL
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_s3ObjectACL
=== RUN   TestAccACMPCACertificateAuthority_RevocationOcsp_enabled
=== PAUSE TestAccACMPCACertificateAuthority_RevocationOcsp_enabled
=== RUN   TestAccACMPCACertificateAuthority_RevocationOcsp_customCNAME
=== PAUSE TestAccACMPCACertificateAuthority_RevocationOcsp_customCNAME
=== RUN   TestAccACMPCACertificateAuthority_tags
=== PAUSE TestAccACMPCACertificateAuthority_tags
=== CONT  TestAccACMPCACertificateAuthorityCertificate_rootCA
=== CONT  TestAccACMPCACertificateAuthority_deleteFromActiveState
--- PASS: TestAccACMPCACertificateAuthority_deleteFromActiveState (21.40s)
=== CONT  TestAccACMPCACertificateAuthorityDataSource_s3ObjectACL
--- PASS: TestAccACMPCACertificateAuthorityCertificate_rootCA (23.14s)
=== CONT  TestAccACMPCACertificateAuthority_enabledDeprecated
--- PASS: TestAccACMPCACertificateAuthorityDataSource_s3ObjectACL (18.48s)
=== CONT  TestAccACMPCACertificateAuthority_disappears
--- PASS: TestAccACMPCACertificateAuthority_disappears (12.23s)
=== CONT  TestAccACMPCACertificateAuthority_basic
--- PASS: TestAccACMPCACertificateAuthority_enabledDeprecated (44.65s)
=== CONT  TestAccACMPCACertificateAuthorityCertificate_subordinateCA
--- PASS: TestAccACMPCACertificateAuthority_basic (18.48s)
=== CONT  TestAccACMPCACertificateAuthorityDataSource_basic
--- PASS: TestAccACMPCACertificateAuthorityDataSource_basic (19.10s)
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_s3ObjectACL
--- PASS: TestAccACMPCACertificateAuthorityCertificate_subordinateCA (25.82s)
=== CONT  TestAccACMPCACertificateAuthority_tags
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_s3ObjectACL (44.45s)
=== CONT  TestAccACMPCACertificateAuthority_RevocationOcsp_customCNAME
--- PASS: TestAccACMPCACertificateAuthority_tags (53.43s)
=== CONT  TestAccACMPCACertificateAuthority_RevocationOcsp_enabled
--- PASS: TestAccACMPCACertificateAuthority_RevocationOcsp_customCNAME (65.01s)
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_enabled
--- PASS: TestAccACMPCACertificateAuthority_RevocationOcsp_enabled (53.90s)
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays (52.26s)
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_enabled (68.51s)
=== CONT  TestAccACMPCACertificateAuthorityCertificate_updateRootCA
--- PASS: TestAccACMPCACertificateAuthorityCertificate_updateRootCA (35.83s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME (85.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acmpca	343.158s

@ewbankkit
Copy link
Contributor

@mattburgess Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4bc826b into hashicorp:main Jul 7, 2022
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/acmpca Issues and PRs that pertain to the acmpca service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.22.0
Development

Successfully merging this pull request may close these issues.

ACMPCA Add support for enabling OCSP
2 participants
@mattburgess @ewbankkit