Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for repository filter to ecr replications #21231

Conversation

stijndehaes
Copy link
Contributor

@stijndehaes stijndehaes commented Oct 11, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21230

Output from acceptance testing:

make testacc PKG_NAME=internal/service/ecr TESTARGS='-run=TestAccECRReplicationConfiguration_repositoryFilter'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run=TestAccECRReplicationConfiguration_repositoryFilter -timeout 180m
=== RUN   TestAccECRReplicationConfiguration_repositoryFilter
=== PAUSE TestAccECRReplicationConfiguration_repositoryFilter
=== CONT  TestAccECRReplicationConfiguration_repositoryFilter
--- PASS: TestAccECRReplicationConfiguration_repositoryFilter (82.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        82.334s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/ecr Issues and PRs that pertain to the ecr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Oct 11, 2021
@stijndehaes stijndehaes force-pushed the f-aws_ecr_replication_configuration-repository_filter branch 4 times, most recently from 5a9e061 to bd3aa2d Compare October 11, 2021 06:05
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 12, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@stijndehaes stijndehaes force-pushed the f-aws_ecr_replication_configuration-repository_filter branch 2 times, most recently from 4d66dd0 to 69659d0 Compare October 21, 2021 08:22
@stijndehaes
Copy link
Contributor Author

@zhelding I updated the PR

Signed-off-by: Stijn De Haes <stijndehaes@gmail.com>
@stijndehaes stijndehaes force-pushed the f-aws_ecr_replication_configuration-repository_filter branch from 69659d0 to 3c71497 Compare October 21, 2021 10:36
@mholttech
Copy link

I was just looking for this exact feature and found this and another PR (#21002) for the same feature to be added to the Provider. Looking forward to seeing one of these merged soon

@ewbankkit
Copy link
Contributor

@stijndehaes Thanks for the contribution 🎉 👏.
I have included your changes in #21002.

@ewbankkit ewbankkit closed this Dec 20, 2021
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECR replication offer support fo repository filters
5 participants