Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support aws_ecr_replication_configuration repository filter #21002

Merged
merged 12 commits into from
Dec 20, 2021
Merged

feat: adding support aws_ecr_replication_configuration repository filter #21002

merged 12 commits into from
Dec 20, 2021

Conversation

uanid
Copy link
Contributor

@uanid uanid commented Sep 23, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20995.
Closes #21230.

Add Repository Filter option to aws_ecr_replication_configuration resource.

# Example Resource

resource "aws_ecr_replication_configuration" "example" {
  replication_configuration {
    rule {
      destination {
        region      = "ap-northeast-1"
        registry_id = data.aws_caller_identity.current.account_id
      }
      repository_filter {
        filter = "aaaa"
        filter_type = "PREFIX_MATCH"
      }
      repository_filter {
        filter = "aaaa2"
        filter_type = "PREFIX_MATCH"
      }
    }
  }
}

References

Output from acceptance testing:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr -v -count 1 -parallel 20 -run=TestAccECRReplicationConfiguration_basic -timeout 180m
=== RUN   TestAccECRReplicationConfiguration_basic
=== PAUSE TestAccECRReplicationConfiguration_basic
=== CONT  TestAccECRReplicationConfiguration_basic
--- PASS: TestAccECRReplicationConfiguration_basic (106.55s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        107.824s

...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ecr Issues and PRs that pertain to the ecr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. labels Sep 23, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @uanid 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 23, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@uanid
Copy link
Contributor Author

uanid commented Oct 20, 2021

Hello @zhelding
I finished refactor this codes. Can you check this Pull Request is acceptable?

Signed-off-by: Stijn De Haes <stijndehaes@gmail.com>
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 20, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc PKG=ecr TESTS=TestAccECRReplicationConfiguration_                       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRReplicationConfiguration_' -timeout 180m
=== RUN   TestAccECRReplicationConfiguration_serial
=== RUN   TestAccECRReplicationConfiguration_serial/basic
=== RUN   TestAccECRReplicationConfiguration_serial/repositoryFilter
--- PASS: TestAccECRReplicationConfiguration_serial (74.43s)
    --- PASS: TestAccECRReplicationConfiguration_serial/basic (38.43s)
    --- PASS: TestAccECRReplicationConfiguration_serial/repositoryFilter (35.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	78.011s

@ewbankkit
Copy link
Contributor

@uanid @stijndehaes Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5098cfd into hashicorp:main Dec 20, 2021
@github-actions github-actions bot added this to the v3.71.0 milestone Dec 20, 2021
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@uanid uanid deleted the feature/ecr-replication-filter branch January 7, 2022 05:38
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
5 participants