Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Configure Point in Time Recovery in DynamoDB Global Tables v2 Replicas #21323

Closed
dallasanta opened this issue Oct 15, 2021 · 2 comments · Fixed by #25659
Closed

Ability to Configure Point in Time Recovery in DynamoDB Global Tables v2 Replicas #21323

dallasanta opened this issue Oct 15, 2021 · 2 comments · Fixed by #25659
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dynamodb Issues and PRs that pertain to the dynamodb service.
Milestone

Comments

@dallasanta
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

DynamoDB Global Tables v2 are configured using the "replica" blocks in the "aws_dynamodb_table" resource. The replicas are then created automatically in the specified regions.

The problem is that with the current configuration it is not possible to set the "point_in_time_recovery" on the replicas. The replica tables are always created as "disabled", irrespective of the aws_dynamodb_table configuration.

It can probably be supported by using "null_resources" but ideally it should be part of the replica configuration.

The ability to configure KMS keys and tags in the replicas has already been implemented as per the links on the Reference section. Cloudformation also allows point_in_time_recovery to be configured per replica.

Affected Resource(s)

  • aws_dynamodb_table

Potential Terraform Configuration

resource "aws_dynamodb_table" "some-table" {
  name = "some-table"
  billing_mode = "PAY_PER_REQUEST"
  hash_key = "some-key"
  stream_enabled = true
  stream_view_type = "NEW_AND_OLD_IMAGES"

  attribute {
    name = "some-key"
    type = "S"
  }

  point_in_time_recovery {
    enabled = true
  }

  replica {
    region_name = "eu-west-2"
    point_in_time_recovery {
      enabled = true
    }
  }
}

References

@dallasanta dallasanta added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 15, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Oct 15, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Oct 19, 2021
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dynamodb Issues and PRs that pertain to the dynamodb service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants