Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to tag DynamoDB global table replicas #13725

Closed
rocking42 opened this issue Jun 12, 2020 · 2 comments · Fixed by #13783
Closed

Unable to tag DynamoDB global table replicas #13725

rocking42 opened this issue Jun 12, 2020 · 2 comments · Fixed by #13783
Labels
new-resource Introduces a new resource. service/dynamodb Issues and PRs that pertain to the dynamodb service.
Milestone
v3.56.0

Comments

@rocking42
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Thanks for the fast work getting the global tables issue resolved so quickly. Currently we're facing the issue where there is no way to add tags to the DynamoDB replicas. I was thinking that either the main tables tags could be added to each replica or allow the replicaUpdate to take both a regionName and an array of tags https://github.com/cmonty/terraform-provider-aws/blob/8854ad1af3d229579bf1aec63fa9feee08d397ac/aws/resource_aws_dynamodb_table.go#L642

New or Affected Resource(s)

  • DynamoDb Global tables v2

References
@rocking42 rocking42 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 12, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 12, 2020
@ewbankkit ewbankkit mentioned this issue Jun 12, 2020
Closed
@bflad bflad added new-resource Introduces a new resource. service/dynamodb Issues and PRs that pertain to the dynamodb service. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jun 17, 2020
bflad added a commit that referenced this issue Jun 17, 2020
@bflad
New Resource: aws_dynamodb_tag
580110c 
Reference: #6859
Reference: #13725

Output from acceptance testing:

```
--- PASS: TestAccAWSDynamodbTag_disappears (27.18s)
--- PASS: TestAccAWSDynamodbTag_basic (31.00s)
--- PASS: TestAccAWSDynamodbTag_Value (42.71s)
--- PASS: TestAccAWSDynamodbTag_ResourceArn_TableReplica (159.24s)
```
@bflad bflad mentioned this issue Jun 17, 2020
Merged
@ewbankkit ewbankkit mentioned this issue Aug 4, 2020
Closed
bflad added a commit that referenced this issue Mar 24, 2021
@bflad
New Resource: aws_dynamodb_tag
08a91ec 
Reference: #6859
Reference: #13725

Output from acceptance testing:

```
--- PASS: TestAccAWSDynamodbTag_disappears (27.18s)
--- PASS: TestAccAWSDynamodbTag_basic (31.00s)
--- PASS: TestAccAWSDynamodbTag_Value (42.71s)
--- PASS: TestAccAWSDynamodbTag_ResourceArn_TableReplica (159.24s)
```
ewbankkit pushed a commit that referenced this issue Aug 20, 2021
@bflad @ewbankkit
New Resource: aws_dynamodb_tag
64fc37a 
Reference: #6859
Reference: #13725

Output from acceptance testing:

```
--- PASS: TestAccAWSDynamodbTag_disappears (27.18s)
--- PASS: TestAccAWSDynamodbTag_basic (31.00s)
--- PASS: TestAccAWSDynamodbTag_Value (42.71s)
--- PASS: TestAccAWSDynamodbTag_ResourceArn_TableReplica (159.24s)
```
@github-actions github-actions bot added this to the v3.56.0 milestone Aug 20, 2021
@github-actions
Copy link

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@dallasanta dallasanta mentioned this issue Oct 15, 2021
Closed
@ewbankkit ewbankkit mentioned this issue Apr 28, 2022
Closed
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
new-resource Introduces a new resource. service/dynamodb Issues and PRs that pertain to the dynamodb service.
Projects
None yet
Milestone
v3.56.0
2 participants
@bflad @rocking42