Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b-aws_dynamodb_table #21334

Merged
merged 3 commits into from
Dec 23, 2021
Merged

b-aws_dynamodb_table #21334

merged 3 commits into from
Dec 23, 2021

Conversation

GlennChia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19344

Output from acceptance testing:

$ TF_ACC=1 go test ./internal/service/dynamodb -v -count 1 -parallel 20 -run='TestAccDynamoDBTable_TTL' -timeout=180m

=== RUN   TestAccDynamoDBTable_TTL_enabled
=== PAUSE TestAccDynamoDBTable_TTL_enabled
=== RUN   TestAccDynamoDBTable_TTL_disabled
=== PAUSE TestAccDynamoDBTable_TTL_disabled
=== CONT  TestAccDynamoDBTable_TTL_enabled
=== CONT  TestAccDynamoDBTable_TTL_disabled
--- PASS: TestAccDynamoDBTable_TTL_enabled (54.04s)
--- PASS: TestAccDynamoDBTable_TTL_disabled (88.98s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   94.710s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XS Managed by automation to categorize the size of a PR. labels Oct 16, 2021
@GlennChia GlennChia changed the title fix: remove extra kms_key_arn from ttl b-aws_dynamodb_table Oct 16, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 22, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDynamoDBTable_' PKG_NAME=internal/service/dynamodb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb -v -count 1 -parallel 20 -run=TestAccDynamoDBTable_ -timeout 180m
=== RUN   TestAccDynamoDBTable_basic
=== PAUSE TestAccDynamoDBTable_basic
=== RUN   TestAccDynamoDBTable_disappears
=== PAUSE TestAccDynamoDBTable_disappears
=== RUN   TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
=== PAUSE TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
=== RUN   TestAccDynamoDBTable_extended
=== PAUSE TestAccDynamoDBTable_extended
=== RUN   TestAccDynamoDBTable_enablePITR
=== PAUSE TestAccDynamoDBTable_enablePITR
=== RUN   TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
=== PAUSE TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
=== RUN   TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
=== PAUSE TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
=== RUN   TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== PAUSE TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== RUN   TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
=== PAUSE TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
=== RUN   TestAccDynamoDBTable_streamSpecification
=== PAUSE TestAccDynamoDBTable_streamSpecification
=== RUN   TestAccDynamoDBTable_streamSpecificationValidation
=== PAUSE TestAccDynamoDBTable_streamSpecificationValidation
=== RUN   TestAccDynamoDBTable_tags
=== PAUSE TestAccDynamoDBTable_tags
=== RUN   TestAccDynamoDBTable_gsiUpdateCapacity
=== PAUSE TestAccDynamoDBTable_gsiUpdateCapacity
=== RUN   TestAccDynamoDBTable_gsiUpdateOtherAttributes
=== PAUSE TestAccDynamoDBTable_gsiUpdateOtherAttributes
=== RUN   TestAccDynamoDBTable_lsiNonKeyAttributes
=== PAUSE TestAccDynamoDBTable_lsiNonKeyAttributes
=== RUN   TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
=== PAUSE TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
=== RUN   TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== PAUSE TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== RUN   TestAccDynamoDBTable_TTL_enabled
=== PAUSE TestAccDynamoDBTable_TTL_enabled
=== RUN   TestAccDynamoDBTable_TTL_disabled
=== PAUSE TestAccDynamoDBTable_TTL_disabled
=== RUN   TestAccDynamoDBTable_attributeUpdate
=== PAUSE TestAccDynamoDBTable_attributeUpdate
=== RUN   TestAccDynamoDBTable_lsiUpdate
=== PAUSE TestAccDynamoDBTable_lsiUpdate
=== RUN   TestAccDynamoDBTable_attributeUpdateValidation
=== PAUSE TestAccDynamoDBTable_attributeUpdateValidation
=== RUN   TestAccDynamoDBTable_encryption
=== PAUSE TestAccDynamoDBTable_encryption
=== RUN   TestAccDynamoDBTable_Replica_multiple
=== PAUSE TestAccDynamoDBTable_Replica_multiple
=== RUN   TestAccDynamoDBTable_Replica_single
=== PAUSE TestAccDynamoDBTable_Replica_single
=== RUN   TestAccDynamoDBTable_Replica_singleWithCMK
=== PAUSE TestAccDynamoDBTable_Replica_singleWithCMK
=== CONT  TestAccDynamoDBTable_basic
=== CONT  TestAccDynamoDBTable_lsiNonKeyAttributes
=== CONT  TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== CONT  TestAccDynamoDBTable_extended
=== CONT  TestAccDynamoDBTable_attributeUpdateValidation
=== CONT  TestAccDynamoDBTable_Replica_singleWithCMK
=== CONT  TestAccDynamoDBTable_Replica_single
=== CONT  TestAccDynamoDBTable_Replica_multiple
=== CONT  TestAccDynamoDBTable_encryption
=== CONT  TestAccDynamoDBTable_TTL_disabled
=== CONT  TestAccDynamoDBTable_lsiUpdate
=== CONT  TestAccDynamoDBTable_attributeUpdate
=== CONT  TestAccDynamoDBTable_streamSpecification
=== CONT  TestAccDynamoDBTable_streamSpecificationValidation
=== CONT  TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
=== CONT  TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== CONT  TestAccDynamoDBTable_TTL_enabled
=== CONT  TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
=== CONT  TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
=== CONT  TestAccDynamoDBTable_tags
--- PASS: TestAccDynamoDBTable_streamSpecificationValidation (8.93s)
=== CONT  TestAccDynamoDBTable_gsiUpdateOtherAttributes
--- PASS: TestAccDynamoDBTable_attributeUpdateValidation (17.02s)
=== CONT  TestAccDynamoDBTable_disappears
--- PASS: TestAccDynamoDBTable_disappears (27.76s)
=== CONT  TestAccDynamoDBTable_gsiUpdateCapacity
--- PASS: TestAccDynamoDBTable_basic (45.05s)
=== CONT  TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
--- PASS: TestAccDynamoDBTable_TTL_enabled (54.85s)
=== CONT  TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
--- PASS: TestAccDynamoDBTable_lsiNonKeyAttributes (55.47s)
=== CONT  TestAccDynamoDBTable_enablePITR
--- PASS: TestAccDynamoDBTable_tags (73.70s)
--- PASS: TestAccDynamoDBTable_streamSpecification (84.58s)
--- PASS: TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan (90.07s)
--- PASS: TestAccDynamoDBTable_TTL_disabled (90.08s)
--- PASS: TestAccDynamoDBTable_lsiUpdate (92.98s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned (99.82s)
--- PASS: TestAccDynamoDBTable_Disappears_payPerRequestWithGSI (106.09s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned (63.57s)
--- PASS: TestAccDynamoDBTable_gsiUpdateCapacity (74.75s)
--- PASS: TestAccDynamoDBTable_enablePITR (72.51s)
--- PASS: TestAccDynamoDBTable_encryption (188.82s)
--- PASS: TestAccDynamoDBTable_gsiUpdateNonKeyAttributes (215.61s)
--- PASS: TestAccDynamoDBTable_extended (216.13s)
--- PASS: TestAccDynamoDBTable_gsiUpdateOtherAttributes (619.74s)
--- PASS: TestAccDynamoDBTable_attributeUpdate (631.37s)
--- PASS: TestAccDynamoDBTable_Replica_single (742.45s)
--- PASS: TestAccDynamoDBTable_Replica_singleWithCMK (982.27s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest (1068.72s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest (1114.65s)
--- PASS: TestAccDynamoDBTable_Replica_multiple (1357.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	1360.147s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit bfe8ac2 into hashicorp:main Dec 23, 2021
@github-actions github-actions bot added this to the v3.71.0 milestone Dec 23, 2021
@GlennChia GlennChia deleted the fix/dynamo-ttl-attr branch December 23, 2021 13:34
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partner Contribution from a partner. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is there a KMS in DDB TTL param?
4 participants