fix: remove extra kms_key_arn from ttl

[GlennChia]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19344

Based on the AWS documentation for the update-time-to-live command, the TimeToLiveSpecification only accepts 2 attributes

• Enabled
• AttributeName

Furthermore, the console documentation also supports the above observation.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDynamoDbTable_Ttl'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDynamoDbTable_Ttl -timeout 180m
=== RUN   TestAccAWSDynamoDbTable_Ttl_enabled
=== PAUSE TestAccAWSDynamoDbTable_Ttl_enabled
=== RUN   TestAccAWSDynamoDbTable_Ttl_disabled
=== PAUSE TestAccAWSDynamoDbTable_Ttl_disabled
=== CONT  TestAccAWSDynamoDbTable_Ttl_enabled
=== CONT  TestAccAWSDynamoDbTable_Ttl_disabled
--- PASS: TestAccAWSDynamoDbTable_Ttl_enabled (60.80s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_disabled (100.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	100.789s

Additional note: Prior to making changes, I ran the full suite of tests using make testacc TESTARGS='-run=TestAccAWSDynamoDbTable' but faced issues with the TestAccAWSDynamoDbTable_BillingMode_GSI_provisionedToPayPerRequest test case. In the test case, there was no mention of ttl so this error is probably due to some other issue and is not related to this PR and the issue that the PR addresses.

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[GlennChia]

Hi @ewbankkit, when I rebased, the commits history became really messy for this PR. Closed this PR in favour of #21334

[obataku]

surely this change should've been accompanied by state migrations to resolve the breaking change?

cc @feelobot

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.