Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AWS Shield Advance Subscriptions #21430

Closed
maunzCache opened this issue Oct 21, 2021 · 9 comments · Fixed by #37637
Closed

Support for AWS Shield Advance Subscriptions #21430

maunzCache opened this issue Oct 21, 2021 · 9 comments · Fixed by #37637
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/shield Issues and PRs that pertain to the shield service.
Milestone

Comments

@maunzCache
Copy link

maunzCache commented Oct 21, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

I would like to use terraform to manage AWS Shield Advance Subscriptions which are available via the API, which is part of AWS WAF.
General documentation can be found here.
Also find information about the boto library or the cli reference.

New or Affected Resource(s)

  • aws_shield_subscription

Potential Terraform Configuration

resource "aws_shield_subscription" "example" {
  name       = "example"
  auto_renew = false # Or true

  tags = {
    Organization = "ACME"
  }
}

The resource is more or less useless because there is no return body for it. Also the auto_renew can only be used with the implementation with UpdateSubscription.
As well i do not know if tags are supported. WAF is listed in general but not shield.

References

None

@maunzCache maunzCache added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 21, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/shield Issues and PRs that pertain to the shield service. labels Oct 21, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 21, 2021
@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Oct 11, 2023
@maunzCache
Copy link
Author

maunzCache commented Oct 11, 2023

Hi Bot, this is still an active request as the like counter is going up.

@github-actions github-actions bot removed the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Oct 11, 2023
@mrbobfrog
Copy link

Ping for activity to keep the bot at bay

@gavreid
Copy link

gavreid commented Jan 9, 2024

+1 - we need this

@ciandt-andregc
Copy link

+1

@okummer
Copy link

okummer commented Mar 7, 2024

Until the feature is implemented, you can create a subscription like this:

resource "null_resource" "aws_shield_create_subscription" {
  provisioner "local-exec" {
    interpreter = ["bash", "-x", "-c"]
    command     = <<EOF
if [ "$(aws shield get-subscription-state --profile ${var.profile_name} --query SubscriptionState --output text)" == INACTIVE ]; then
  echo Creating AWS Shield Advanced subscription ...
  aws shield create-subscription --profile ${var.profile_name}
  echo Done.
else
  echo AWS Shield Advanced subscription is already active.
fi
EOF
  }
}

Note that a subscription cannot be removed programmatically. You need to open a support case for that. A subscription can cost thousand of dollars per month, so use this code wisely.

iwarapter added a commit to iwarapter/terraform-provider-aws that referenced this issue May 22, 2024
jar-b added a commit that referenced this issue Jul 24, 2024
add support for aws shield subscription resource fixes #21430
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.60.0 milestone Jul 24, 2024
Copy link

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/shield Issues and PRs that pertain to the shield service.
Projects
None yet
6 participants