Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_codecommit_approval_rule_template #21768

Closed
evairmarinho opened this issue Nov 14, 2021 · 3 comments
Closed

New resource: aws_codecommit_approval_rule_template #21768

evairmarinho opened this issue Nov 14, 2021 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/codecommit Issues and PRs that pertain to the codecommit service.

Comments

@evairmarinho
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS CLI doc:

  • "Creates a template for approval rules that can then be associated with one or more repositories in your AWS account. When you associate a template with a repository, AWS CodeCommit creates an approval rule that matches the conditions of the template for all pull requests that meet the conditions of the template"

New or Affected Resource(s)

  • aws_codecommit_approval_rule_template

Potential Terraform Configuration

resource "aws_codecommit_approval_rule_template" {
  name        = "my_approval_rule_template"
  description = "Approval rule template for my CodeCommit repository"
  content     = <<EOF
{
 "Version": "2018-11-08",
"DestinationReferences": ["refs/heads/main"],
"Statements: [
{
"Type": "Approvers", 
"NumberOfApprovalsNeeded": 2,
"ApprovalPoolMembers": ["arn:aws:sts::123456789012:assumed-role/CodeCommitReview/*"]
}
]
}
EOF
}

References

@evairmarinho evairmarinho added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 14, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/codecommit Issues and PRs that pertain to the codecommit service. labels Nov 14, 2021
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 15, 2021
@evairmarinho
Copy link
Author

#11461 Already exist @justinretzolk

@evairmarinho
Copy link
Author

Already exist the issue for this.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/codecommit Issues and PRs that pertain to the codecommit service.
Projects
None yet
Development

No branches or pull requests

2 participants