Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource for CodeCommit approval rule templates #11461

Closed
double16 opened this issue Jan 2, 2020 · 7 comments · Fixed by #11487
Closed

Add resource for CodeCommit approval rule templates #11461

double16 opened this issue Jan 2, 2020 · 7 comments · Fixed by #11487
Assignees
Labels
new-resource Introduces a new resource. service/codecommit Issues and PRs that pertain to the codecommit service.
Milestone

Comments

@double16
Copy link

double16 commented Jan 2, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS recently added approval rule templates to CodeCommit to improve the pull request process. Need to add a resource for this.

New or Affected Resource(s)

  • aws_codecommit_approval_rule_template

References

@double16 double16 added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 2, 2020
@ghost ghost added the service/codecommit Issues and PRs that pertain to the codecommit service. label Jan 2, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 2, 2020
@carthewd
Copy link
Contributor

carthewd commented Jan 6, 2020

I have built a working resource for this - I'm just updating the documentation and then I'll submit the PR

@epk910
Copy link

epk910 commented Jan 23, 2020

+1

1 similar comment
@a-weiss-programmer
Copy link

+1

@lakshmigk01
Copy link

+1

@breathingdust breathingdust added new-resource Introduces a new resource. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Sep 22, 2021
@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

This functionality has been released in v3.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/codecommit Issues and PRs that pertain to the codecommit service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants