CodeCommit approval rule template association

[carthewd]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11461

Release note for CHANGELOG:

New Resource: aws_codecommit_approval_rule_association

Example

resource "aws_codecommit_approval_rule_association" "test" {
    template_name = "test2-rule"
    repository_names = ["test1", "test2"]
}

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeCommitApprovalRuleAssociation'                                                                  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeCommitApprovalRuleAssociation -timeout 120m
=== RUN   TestAccAWSCodeCommitApprovalRuleAssociation_basic
=== PAUSE TestAccAWSCodeCommitApprovalRuleAssociation_basic
=== RUN   TestAccAWSCodeCommitApprovalRuleAssociation_withChanges
=== PAUSE TestAccAWSCodeCommitApprovalRuleAssociation_withChanges
=== CONT  TestAccAWSCodeCommitApprovalRuleAssociation_basic
=== CONT  TestAccAWSCodeCommitApprovalRuleAssociation_withChanges
--- PASS: TestAccAWSCodeCommitApprovalRuleAssociation_basic (41.50s)
--- PASS: TestAccAWSCodeCommitApprovalRuleAssociation_withChanges (82.65s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       82.691s

[xenji]

Hey folks, any news when this will hit the release train? Would be highly appreciated!

[teamterraform]

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

[nickjmv]

Hi, any idea when this will be merged?

[DrFaust92]

Hi @carthewd, thanks for the contribution. some comments + take a look at https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/CONTRIBUTING.md for for more things like using finder functions and adding disappears test

[johngmyers]

How is it that this PR closes #11461? This PR creates approval rule associations, whereas #11461 asks for approval rule templates.

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[anGie44]

Hi again @carthewd , thank you for this PR! I'm going to be reviewing this PR and in the meantime, I recommend setting this PR to allow maintainers to edit so that we can help you update this PR for service packages (see #20000). If edits are possible, I will resolve merge conflicts on my end and get this ready for an upcoming release.

[anGie44]

Output of acceptance tests: (AWS Commercial):

--- PASS: TestAccCodeCommitApprovalRuleTemplate_disappears (15.48s)
--- PASS: TestAccCodeCommitApprovalRuleTemplateDataSource_basic (17.29s)
--- PASS: TestAccCodeCommitApprovalRuleTemplateAssociation_Disappears_repository (18.79s)
--- PASS: TestAccCodeCommitApprovalRuleTemplateAssociation_disappears (18.79s)
--- PASS: TestAccCodeCommitApprovalRuleTemplate_basic (19.37s)
--- PASS: TestAccCodeCommitApprovalRuleTemplateAssociation_basic (21.00s)
--- PASS: TestAccCodeCommitApprovalRuleTemplate_updateContentAndDescription (28.82s)
--- PASS: TestAccCodeCommitApprovalRuleTemplate_updateName (28.83s)

[anGie44]

Thanks again @carthewd for your contributions! Similar to #11487 , I've committed changes to fix merge conflicts that arose with the service packages restructure, and made updates to align with more recent contributing guidelines.

[github-actions]

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.