Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/codepipeline_webhook - validations #22406

Merged
merged 5 commits into from
Jan 5, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 4, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15804
Relates #17482
Relates #14668

Output from acceptance testing:

$ make testacc TESTS=TestAccCodePipelineWebhook_ PKG=codepipeline
--- PASS: TestAccCodePipelineWebhook_basic (234.41s)
--- PASS: TestAccCodePipelineWebhook_ipAuth (96.06s)
--- PASS: TestAccCodePipelineWebhook_unauthenticated (92.08s)
--- PASS: TestAccCodePipelineWebhook_disappears (87.05s)
--- PASS: TestAccCodePipelineWebhook_UpdateAuthentication_secretToken (153.73s)
--- PASS: TestAccCodePipelineWebhook_tags (236.56s)

@github-actions github-actions bot added service/codepipeline Issues and PRs that pertain to the codepipeline service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jan 4, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jan 5, 2022
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 5, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review January 5, 2022 09:17
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccCodePipelineWebhook_ PKG=codepipeline
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codepipeline/... -v -count 1 -parallel 20 -run='TestAccCodePipelineWebhook_' -timeout 180m
=== RUN   TestAccCodePipelineWebhook_basic
--- PASS: TestAccCodePipelineWebhook_basic (91.62s)
=== RUN   TestAccCodePipelineWebhook_ipAuth
--- PASS: TestAccCodePipelineWebhook_ipAuth (34.74s)
=== RUN   TestAccCodePipelineWebhook_unauthenticated
--- PASS: TestAccCodePipelineWebhook_unauthenticated (36.53s)
=== RUN   TestAccCodePipelineWebhook_tags
--- PASS: TestAccCodePipelineWebhook_tags (96.02s)
=== RUN   TestAccCodePipelineWebhook_disappears
--- PASS: TestAccCodePipelineWebhook_disappears (36.58s)
=== RUN   TestAccCodePipelineWebhook_UpdateAuthentication_secretToken
--- PASS: TestAccCodePipelineWebhook_UpdateAuthentication_secretToken (137.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline	442.167s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0a4fc20 into hashicorp:main Jan 5, 2022
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 5, 2022
@DrFaust92 DrFaust92 deleted the codepipe_webhook branch January 5, 2022 14:33
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codepipeline Issues and PRs that pertain to the codepipeline service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodePipeline webhook is not updating filter
2 participants