r/s3_bucket_website_configuration: new resource

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433

Output from acceptance testing:

--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (29.72s)
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (33.03s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_RedirectOnly (33.37s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (33.38s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (51.82s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_MultipleRules (53.22s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (81.73s)

[gdavison]

Looks good! One question about the ordering of rules

[gdavison]

Is there any ordering to the redirect rules? E.g. if I create rules like

`docs/`        => destinationA
`docs/images/` => destinationB

does the order in the generated JSON matter?

[anGie44]

Ooo that's a good question, and i want to say it does matter so this should really be a List 🤦‍♀️ ..also the aws_s3_bucket resource's routing_rules argument doesn't have any

DiffSuppressFunc: verify.SuppressEquivalentJSONDiffs,

which makes me think the List is more appropriate

[anGie44]

updated to TypeList in a90dcdc to follow what Cloud Control does in its schema 👍

[anGie44]

Output of acceptance tests after a90dcdc:

--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (31.34s)
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (34.80s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_RedirectOnly (34.82s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (34.86s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (56.15s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_MultipleRules (57.64s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (93.74s)

[gdavison]

Looks good! 🚀

--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (46.52s)
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (52.00s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_RedirectOnly (52.13s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (52.22s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (71.78s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_MultipleRules (72.15s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (97.63s)

[github-actions]

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.