Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket: read-only website, website_endpoint, and website_domain arguments #22614

Merged
merged 12 commits into from
Feb 4, 2022
Merged

r/s3_bucket: read-only website, website_endpoint, and website_domain arguments #22614

merged 12 commits into from
Feb 4, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 16, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433

Output from acceptance testing:

    --- PASS: TestParseRecordId/ABCDEF (0.00s)
    --- PASS: TestParseRecordId/ABCDEF__underscore.example.com_A (0.00s)
    --- PASS: TestParseRecordId/ABCDEF__underscore.example.com_A_set1 (0.00s)
    --- PASS: TestParseRecordId/ABCDEF__underscore.example.com_A_set_with1 (0.00s)
    --- PASS: TestParseRecordId/ABCDEF__underscore.example.com_A_set_with_1 (0.00s)
    --- PASS: TestParseRecordId/ABCDEF_prefix._underscore.example.com_A (0.00s)
    --- PASS: TestParseRecordId/ABCDEF_prefix._underscore.example.com_A_set (0.00s)
    --- PASS: TestParseRecordId/ABCDEF_prefix._underscore.example.com_A_set_underscore (0.00s)
    --- PASS: TestParseRecordId/ABCDEF_test.example.com (0.00s)
    --- PASS: TestParseRecordId/ABCDEF_test.example.com._A (0.00s)
    --- PASS: TestParseRecordId/ABCDEF_test.example.com_A (0.00s)
    --- PASS: TestParseRecordId/ABCDEF_test.example.com_A_set1 (0.00s)

--- PASS: TestAccCloudFormationStackDataSource_DataSource_basic (114.60s)
--- PASS: TestAccCloudFormationStackDataSource_DataSource_yaml (114.55s)

--- PASS: TestAccCloudFormationStackSetInstance_Disappears_stackSet (160.61s)
--- PASS: TestAccCloudFormationStackSetInstance_basic (177.67s)
--- PASS: TestAccCloudFormationStackSetInstance_disappears (164.25s)
--- PASS: TestAccCloudFormationStackSetInstance_parameterOverrides (319.49s)
--- PASS: TestAccCloudFormationStackSetInstance_retainStack (259.16s)

--- PASS: TestAccCloudFormationStackSet_administrationRoleARN (129.82s)
--- PASS: TestAccCloudFormationStackSet_basic (71.46s)
--- PASS: TestAccCloudFormationStackSet_description (130.54s)
--- PASS: TestAccCloudFormationStackSet_disappears (73.71s)
--- PASS: TestAccCloudFormationStackSet_executionRoleName (134.42s)
--- PASS: TestAccCloudFormationStackSet_name (145.93s)
--- PASS: TestAccCloudFormationStackSet_parameters (203.34s)
--- PASS: TestAccCloudFormationStackSet_tags (207.96s)
--- PASS: TestAccCloudFormationStackSet_templateBody (135.25s)
--- PASS: TestAccCloudFormationStackSet_templateURL (117.06s)

--- PASS: TestAccCloudFormationStack_CreationFailure_delete (75.96s)
--- PASS: TestAccCloudFormationStack_CreationFailure_doNothing (57.92s)
--- PASS: TestAccCloudFormationStack_CreationFailure_rollback (77.71s)
--- PASS: TestAccCloudFormationStack_allAttributes (119.83s)
--- PASS: TestAccCloudFormationStack_basic (118.84s)
--- PASS: TestAccCloudFormationStack_defaultParams (99.52s)
--- PASS: TestAccCloudFormationStack_disappears (87.05s)
--- PASS: TestAccCloudFormationStack_onFailure (85.85s)
--- PASS: TestAccCloudFormationStack_updateFailure (144.28s)
--- PASS: TestAccCloudFormationStack_withParams (157.98s)
--- PASS: TestAccCloudFormationStack_withTransform (95.04s)
--- PASS: TestAccCloudFormationStack_yaml (104.96s)

--- PASS: TestAccRoute53Record_Alias_elb (240.74s)
--- PASS: TestAccRoute53Record_Alias_uppercase (213.55s)
--- PASS: TestAccRoute53Record_Alias_vpcEndpoint (625.71s)
--- PASS: TestAccRoute53Record_Basic_fqdn (291.72s)
--- PASS: TestAccRoute53Record_Basic_trailingPeriodAndZoneID (254.28s)
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (266.56s)
--- PASS: TestAccRoute53Record_Geolocation_basic (279.08s)
--- PASS: TestAccRoute53Record_HealthCheckID_setIdentifierChange (426.50s)
--- PASS: TestAccRoute53Record_HealthCheckID_typeChange (443.48s)
--- PASS: TestAccRoute53Record_Latency_basic (263.10s)
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (279.75s)
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (285.12s)
--- PASS: TestAccRoute53Record_Weighted_alias (426.55s)
--- PASS: TestAccRoute53Record_Weighted_basic (303.65s)
--- PASS: TestAccRoute53Record_aliasChange (381.98s)
--- PASS: TestAccRoute53Record_allowOverwrite (264.06s)
--- PASS: TestAccRoute53Record_basic (174.41s)
--- PASS: TestAccRoute53Record_caaSupport (157.83s)
--- PASS: TestAccRoute53Record_disappears (225.89s)
--- PASS: TestAccRoute53Record_doNotAllowOverwrite (164.44s)
--- PASS: TestAccRoute53Record_dsSupport (255.64s)
--- PASS: TestAccRoute53Record_empty (250.51s)
--- PASS: TestAccRoute53Record_failover (240.13s)
--- PASS: TestAccRoute53Record_generatesSuffix (170.11s)
--- PASS: TestAccRoute53Record_longTXTrecord (266.52s)
--- PASS: TestAccRoute53Record_nameChange (449.98s)
--- PASS: TestAccRoute53Record_setIdentifierChange (404.63s)
--- PASS: TestAccRoute53Record_spfSupport (245.11s)
--- PASS: TestAccRoute53Record_txtSupport (296.20s)
--- PASS: TestAccRoute53Record_typeChange (394.91s)
--- PASS: TestAccRoute53Record_underscored (228.04s)
--- PASS: TestAccRoute53Record_wildcard (425.23s)

--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (26.62s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (252.21s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (256.13s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (256.61s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (257.47s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (257.59s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (164.62s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (26.45s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (164.75s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (162.15s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_removed (241.13s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (356.69s)

--- PASS: TestAccS3BucketDataSource_basic (148.92s)

--- PASS: TestAccS3BucketIntelligentTieringConfiguration_Filter (517.63s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (161.55s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_disappears (146.39s)

--- PASS: TestAccS3BucketInventory_basic (164.34s)
--- PASS: TestAccS3BucketInventory_encryptWithSSEKMS (164.99s)
--- PASS: TestAccS3BucketInventory_encryptWithSSES3 (165.87s)

--- PASS: TestAccS3BucketMetric_basic (163.12s)
--- PASS: TestAccS3BucketMetric_withEmptyFilter (30.40s)
--- PASS: TestAccS3BucketMetric_withFilterMultipleTags (231.08s)
--- PASS: TestAccS3BucketMetric_withFilterPrefix (252.11s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndMultipleTags (248.03s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndSingleTag (233.06s)
--- PASS: TestAccS3BucketMetric_withFilterSingleTag (230.08s)

--- PASS: TestAccS3BucketNotification_LambdaFunctionLambdaFunctionARN_alias (161.24s)
--- PASS: TestAccS3BucketNotification_Topic_multiple (139.29s)
--- PASS: TestAccS3BucketNotification_lambdaFunction (161.12s)
--- PASS: TestAccS3BucketNotification_queue (171.68s)
--- PASS: TestAccS3BucketNotification_topic (140.74s)
--- PASS: TestAccS3BucketNotification_update (243.93s)

--- PASS: TestAccS3BucketObjectDataSource_allParams (124.90s)
--- PASS: TestAccS3BucketObjectDataSource_basic (122.22s)
--- PASS: TestAccS3BucketObjectDataSource_basicViaAccessPoint (127.56s)
--- PASS: TestAccS3BucketObjectDataSource_bucketKeyEnabled (125.59s)
--- PASS: TestAccS3BucketObjectDataSource_kmsEncrypted (122.31s)
--- PASS: TestAccS3BucketObjectDataSource_leadingSlash (196.12s)
--- PASS: TestAccS3BucketObjectDataSource_multipleSlashes (191.24s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOff (124.26s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOn (120.54s)
--- PASS: TestAccS3BucketObjectDataSource_readableBody (127.35s)
--- PASS: TestAccS3BucketObjectDataSource_singleSlashAsKey (111.62s)

--- PASS: TestAccS3BucketObject_acl (259.07s)
--- PASS: TestAccS3BucketObject_bucketBucketKeyEnabled (92.91s)
--- PASS: TestAccS3BucketObject_content (121.91s)
--- PASS: TestAccS3BucketObject_contentBase64 (103.55s)
--- PASS: TestAccS3BucketObject_defaultBucketSSE (93.80s)
--- PASS: TestAccS3BucketObject_empty (123.88s)
--- PASS: TestAccS3BucketObject_etagEncryption (120.71s)
--- PASS: TestAccS3BucketObject_ignoreTags (162.96s)
--- PASS: TestAccS3BucketObject_kms (115.14s)
--- PASS: TestAccS3BucketObject_metadata (255.37s)
--- PASS: TestAccS3BucketObject_noNameNoKey (33.49s)
--- PASS: TestAccS3BucketObject_nonVersioned (117.14s)
--- PASS: TestAccS3BucketObject_objectBucketKeyEnabled (91.08s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithNone (238.83s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithOn (166.24s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithNone (240.72s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithSet (308.37s)
--- PASS: TestAccS3BucketObject_source (122.13s)
--- PASS: TestAccS3BucketObject_sourceHashTrigger (191.48s)
--- PASS: TestAccS3BucketObject_sse (116.73s)
--- PASS: TestAccS3BucketObject_storageClass (401.41s)
--- PASS: TestAccS3BucketObject_tags (326.76s)
--- PASS: TestAccS3BucketObject_tagsLeadingMultipleSlashes (312.26s)
--- PASS: TestAccS3BucketObject_tagsLeadingSingleSlash (324.97s)
--- PASS: TestAccS3BucketObject_tagsMultipleSlashes (313.84s)
--- PASS: TestAccS3BucketObject_updateSameFile (174.76s)
--- PASS: TestAccS3BucketObject_updates (190.16s)
--- PASS: TestAccS3BucketObject_updatesWithVersioning (187.92s)
--- PASS: TestAccS3BucketObject_updatesWithVersioningViaAccessPoint (180.17s)
--- PASS: TestAccS3BucketObject_withContentCharacteristics (100.80s)

--- PASS: TestAccS3BucketObjectsDataSource_all (168.57s)
--- PASS: TestAccS3BucketObjectsDataSource_basic (165.86s)
--- PASS: TestAccS3BucketObjectsDataSource_basicViaAccessPoint (165.68s)
--- PASS: TestAccS3BucketObjectsDataSource_encoded (165.72s)
--- PASS: TestAccS3BucketObjectsDataSource_fetchOwner (166.29s)
--- PASS: TestAccS3BucketObjectsDataSource_maxKeys (166.26s)
--- PASS: TestAccS3BucketObjectsDataSource_prefixes (169.26s)
--- PASS: TestAccS3BucketObjectsDataSource_startAfter (167.21s)

--- PASS: TestAccS3BucketOwnershipControls_Disappears_bucket (80.12s)
--- PASS: TestAccS3BucketOwnershipControls_Rule_objectOwnership (180.37s)
--- PASS: TestAccS3BucketOwnershipControls_basic (104.05s)
--- PASS: TestAccS3BucketOwnershipControls_disappears (90.57s)

--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (360.21s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (268.66s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (292.60s)

--- PASS: TestAccS3BucketPolicy_basic (102.29s)
--- PASS: TestAccS3BucketPolicy_policyUpdate (184.75s)

--- PASS: TestAccS3BucketPublicAccessBlock_Disappears_bucket (78.97s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (106.79s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicACLs (251.65s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicPolicy (252.45s)
--- PASS: TestAccS3BucketPublicAccessBlock_disappears (89.80s)
--- PASS: TestAccS3BucketPublicAccessBlock_ignorePublicACLs (252.76s)
--- PASS: TestAccS3BucketPublicAccessBlock_restrictPublicBuckets (251.33s)

--- PASS: TestAccS3BucketReplicationConfiguration_basic (533.10s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (485.93s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (487.00s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (139.03s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (359.12s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (363.32s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (407.17s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (403.72s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (400.97s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (401.29s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (392.72s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (366.28s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (234.15s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (407.14s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (312.48s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (400.01s)

--- PASS: TestAccS3BucketVersioning_MFADelete (78.29s)
--- PASS: TestAccS3BucketVersioning_basic (94.11s)
--- PASS: TestAccS3BucketVersioning_disappears (86.64s)
--- PASS: TestAccS3BucketVersioning_update (142.36s)

--- PASS: TestAccS3Bucket_Basic_acceleration (63.61s)
--- PASS: TestAccS3Bucket_Basic_basic (59.38s)
--- PASS: TestAccS3Bucket_Basic_emptyString (55.75s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (94.30s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (94.18s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (94.89s)
--- PASS: TestAccS3Bucket_Basic_generatedName (38.66s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (51.54s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (38.26s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (64.85s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (38.73s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (69.34s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (220.26s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (153.47s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (89.13s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (69.00s)
--- PASS: TestAccS3Bucket_Manage_objectLock (154.64s)
--- PASS: TestAccS3Bucket_Manage_versioning (149.94s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (72.07s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (66.92s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (261.60s)
--- PASS: TestAccS3Bucket_Replication_basic (291.66s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (76.51s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (159.27s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (159.77s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (213.27s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (214.44s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (305.08s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (112.24s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (161.01s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (154.22s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (159.16s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (78.12s)
--- PASS: TestAccS3Bucket_Security_corsDelete (58.87s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (76.29s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (141.48s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (95.92s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (47.02s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (47.84s)
--- PASS: TestAccS3Bucket_Security_grantToACL (86.71s)
--- PASS: TestAccS3Bucket_Security_logging (77.47s)
--- PASS: TestAccS3Bucket_Security_policy (97.67s)
--- PASS: TestAccS3Bucket_Security_updateACL (64.72s)
--- PASS: TestAccS3Bucket_Security_updateGrant (108.19s)
--- PASS: TestAccS3Bucket_Tags_basic (38.19s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (57.56s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (128.24s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (169.85s)

--- PASS: TestBucketName (0.00s)
--- PASS: TestBucketRegionalDomainName (0.00s)
--- PASS: TestCleanRecordName (0.00s)
--- PASS: TestExpandRecordName (0.00s)
--- PASS: TestNormalizeAliasName (0.00s)
--- PASS: TestParseRecordId (0.01s)
--- PASS: TestWebsiteEndpoint (0.00s)

--- SKIP: TestAccCloudFormationStackSetInstance_deploymentTargets (0.00s)
--- SKIP: TestAccCloudFormationStackSet_Parameters_default (0.00s)
--- SKIP: TestAccCloudFormationStackSet_Parameters_noEcho (0.00s)
--- SKIP: TestAccCloudFormationStackSet_PermissionModel_serviceManaged (0.00s)
--- SKIP: TestAccCloudFormationStack_WithURLWithParams_noUpdate (0.00s)
--- SKIP: TestAccCloudFormationStack_WithURLWithParams_withYAML (0.00s)
--- SKIP: TestAccCloudFormationStack_WithURL_withParams (0.00s)
--- SKIP: TestAccRoute53Record_Alias_s3 (0.00s)
--- SKIP: TestAccS3BucketDataSource_website (0.00s)
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jan 16, 2022
@anGie44 anGie44 added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jan 16, 2022
anGie44 added a commit that referenced this pull request Jan 16, 2022
@anGie44
Update CHANGELOG for #22614
c6e722f
@anGie44 anGie44 changed the base branch from main to release/4.x January 16, 2022 03:38
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 2 times, most recently from 44a00a8 to 5ac8e8c Compare January 26, 2022 18:37
anGie44 added a commit that referenced this pull request Jan 26, 2022
@anGie44
Update CHANGELOG for #22614
39a3568
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-website branch from 612ba59 to 3693334 Compare January 26, 2022 21:47
@github-actions github-actions bot added service/cloudformation Issues and PRs that pertain to the cloudformation service. service/route53 Issues and PRs that pertain to the route53 service. labels Jan 26, 2022
anGie44 added a commit that referenced this pull request Jan 27, 2022
@anGie44
Update CHANGELOG for #22614
6ae050b
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-website branch from 607d816 to 1c9cc90 Compare January 27, 2022 04:52
@github-actions github-actions bot added service/cloudformation Issues and PRs that pertain to the cloudformation service. service/route53 Issues and PRs that pertain to the route53 service. and removed service/route53 Issues and PRs that pertain to the route53 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. labels Jan 27, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-website branch from 9b4a3ef to 46d1359 Compare January 27, 2022 05:08
anGie44
anGie44 commented Jan 27, 2022
View reviewed changes
internal/service/s3/bucket_test.go
@@ -637,148 +637,6 @@ func TestAccS3Bucket_Security_grantToACL(t *testing.T) {
})
}

func TestAccS3Bucket_Web_simple(t *testing.T) {
Copy link
Contributor Author

@anGie44 anGie44 Jan 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests have been ported over to #22648

@anGie44
Copy link
Contributor Author

anGie44 commented Jan 27, 2022

Optionally preceded by #22648

@anGie44 anGie44 marked this pull request as ready for review January 27, 2022 07:10
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 13942a7 to e604544 Compare January 28, 2022 22:15
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-website branch from ef33012 to fb52f11 Compare February 3, 2022 05:48
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 3, 2022 •
edited
Loading

Output of aws_s3_bucket_website_configuration tests now that lifecycle block can be removed:

--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (31.88s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (37.15s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_RedirectOnly (37.17s)
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (37.36s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (60.42s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_MultipleRules (61.16s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (95.95s)

@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-website branch from 9e3c915 to 3544e8b Compare February 3, 2022 16:38
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-website branch from 3544e8b to a852262 Compare February 3, 2022 16:39
anGie44 and others added 11 commits February 3, 2022 17:39
@anGie44
feat: deprecate 'website', 'website_endpoint', and 'website_domain' a…
9336898 
…rguments
@anGie44
Update CHANGELOG for #22614
762c1f1
@anGie44
Update .changelog/22614.txt
5d33a9e
@anGie44
cloudformation/stack: migrate tests to use aws_s3_bucket_website_conf…
c26a9c6 
…iguration resource
@anGie44
r/s3_bucket_website_configuration: add website_domain and website_end…
ee0c351 
…point to support route53_record resources
@anGie44
route53/record: migrate test to use aws_s3_bucket_website_configurati…
37c59de 
…on resource
@anGie44
s3/bucket_data_source: migrate test to use aws_s3_bucket_website_conf…
2a29a75 
…iguration resource
@anGie44
add instructions for breaking change introduced in #22614
7284a5c
@anGie44
r/s3_bucket_website_configuration: safe to remove lifecycle ignore_ch…
f8a16ea 
…anges
@anGie44
r/s3_bucket_website_configuration: update destroy/exists checks with …
04233b3 
…ID parse method
@anGie44
Update website/docs/guides/version-4-upgrade.html.md
5be33bd
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-website branch from a852262 to 5be33bd Compare February 3, 2022 22:39
@anGie44 anGie44 merged commit bb560f7 into main Feb 4, 2022
@anGie44 anGie44 deleted the f-s3-bucket-deprecate-website branch February 4, 2022 00:28
@anGie44 anGie44 mentioned this pull request Feb 6, 2022
Closed
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/route53 Issues and PRs that pertain to the route53 service. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anGie44 @gdavison @ewbankkit