Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_iam_policy_document: Deprecate source_json, override_json #22890

Merged
merged 1 commit into from
Feb 2, 2022
Merged

d/aws_iam_policy_document: Deprecate source_json, override_json #22890

merged 1 commit into from
Feb 2, 2022

Conversation

zhelding
Copy link
Contributor

@zhelding zhelding commented Feb 1, 2022 •
edited by anGie44
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17555. (argument removal will take place with #22906)
Closes #22890.

Output from acceptance testing:

n/a

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. labels Feb 1, 2022
@zhelding zhelding force-pushed the td-iam_policy-deprecate branch from f50aebb to 4e9d27d Compare February 1, 2022 22:31
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 1, 2022
@ewbankkit ewbankkit added this to the v4.0.0 milestone Feb 2, 2022
ewbankkit
ewbankkit approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 mentioned this pull request Feb 2, 2022
Closed
@zhelding zhelding merged commit 244f377 into main Feb 2, 2022
@zhelding zhelding deleted the td-iam_policy-deprecate branch February 2, 2022 18:42
github-actions bot pushed a commit that referenced this pull request Feb 2, 2022
Update CHANGELOG.md for #22890
2424603
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

data-source/iam_policy_document: Deprecate source_json and override_json
2 participants
@zhelding @ewbankkit