Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tagging support for AMP workspaces #23202

Merged
merged 11 commits into from
Feb 15, 2022
Merged

Conversation

mhausenblas
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23172

Output from acceptance testing:

$ make testacc TESTS=TestAccAMPWorkspace_tagging PKG=amp                                                                                                                                                                                                                                                           ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amp/... -v -count 1 -parallel 20 -run='TestAccAMPWorkspace_tagging'  -timeout 180m
=== RUN   TestAccAMPWorkspace_tagging
=== PAUSE TestAccAMPWorkspace_tagging
=== CONT  TestAccAMPWorkspace_tagging
--- PASS: TestAccAMPWorkspace_tagging (53.55s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/amp        59.498s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/amp Issues and PRs that pertain to the amp service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 15, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mhausenblas 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 15, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAMPWorkspace_ PKG=amp 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amp/... -v -count 1 -parallel 20 -run='TestAccAMPWorkspace_'  -timeout 180m
=== RUN   TestAccAMPWorkspace_basic
=== PAUSE TestAccAMPWorkspace_basic
=== RUN   TestAccAMPWorkspace_disappears
=== PAUSE TestAccAMPWorkspace_disappears
=== RUN   TestAccAMPWorkspace_tags
=== PAUSE TestAccAMPWorkspace_tags
=== CONT  TestAccAMPWorkspace_basic
=== CONT  TestAccAMPWorkspace_tags
=== CONT  TestAccAMPWorkspace_disappears
--- PASS: TestAccAMPWorkspace_disappears (25.77s)
--- PASS: TestAccAMPWorkspace_basic (68.36s)
--- PASS: TestAccAMPWorkspace_tags (85.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amp	93.392s

@ewbankkit
Copy link
Contributor

@mhausenblas Thanks for the contribution 🎉 👏.
I fixed a couple of minor things to follow our tagging contribution checklist but in general everything was great.

@ewbankkit ewbankkit merged commit e52bb9f into hashicorp:main Feb 15, 2022
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 15, 2022
@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/amp Issues and PRs that pertain to the amp service. size/L Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tagging support for AMP workspaces
2 participants