Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_networkmanager_core_network_policy_document: Allow 4-byte ASNs #24902

Closed
ewbankkit opened this issue May 20, 2022 · 3 comments · Fixed by #27305
Closed

d/aws_networkmanager_core_network_policy_document: Allow 4-byte ASNs #24902

ewbankkit opened this issue May 20, 2022 · 3 comments · Fixed by #27305
Labels
bug Addresses a defect in current functionality. service/networkmanager Issues and PRs that pertain to the networkmanager service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

To unblock the v4.15.0 release #24890 removed the validation on the new aws_networkmanager_core_network_policy_document data source's asn argument.

We should restore the validation and convert the argument to TypeString.
See

for examples on how to achieve this.

@ewbankkit
Copy link
Contributor Author

Alternatively, migrate this data source to terraform-plugin-framework (#23948), as Int64 is a native type there.

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. service/networkmanager Issues and PRs that pertain to the networkmanager service. labels May 20, 2022
@github-actions github-actions bot removed bug Addresses a defect in current functionality. service/networkmanager Issues and PRs that pertain to the networkmanager service. labels May 20, 2022
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. service/networkmanager Issues and PRs that pertain to the networkmanager service. labels May 20, 2022
@github-actions github-actions bot added this to the v4.38.0 milestone Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

This functionality has been released in v4.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/networkmanager Issues and PRs that pertain to the networkmanager service.
Projects
None yet
1 participant