Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove integer constant causing overflow on BSD go-releaser build #24890

Merged
merged 2 commits into from
May 20, 2022
Merged

Remove integer constant causing overflow on BSD go-releaser build #24890

merged 2 commits into from
May 20, 2022

Conversation

zhelding
Copy link
Contributor

@zhelding zhelding commented May 19, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

❯ make testacc TESTS=TestAccNetworkManagerCoreNetworkPolicyDocument PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerCoreNetworkPolicyDocument'  -timeout 180m
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (8.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     8.749s

@github-actions github-actions bot added service/networkmanager Issues and PRs that pertain to the networkmanager service. size/XS Managed by automation to categorize the size of a PR. labels May 19, 2022
@zhelding
networkmanager: remove ValidateFunc for asn attribute
c80451c 
- At least one `asn` provided in the Terraform config must be in the
  range of 4200000000 and 4294967294
- However: including this value in a ValidateFunc causes an integer
  overflow when building the release for freebsd
gdavison
gdavison approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for unblocking the release 🚀

internal/service/networkmanager/core_network_policy_document_data_source.go Show resolved Hide resolved
@zhelding zhelding marked this pull request as ready for review May 20, 2022 00:50
@zhelding zhelding merged commit 5b2d3d9 into main May 20, 2022
@zhelding zhelding deleted the b-networkmanager-bsd-overflow branch May 20, 2022 01:43
@github-actions github-actions bot added this to the v4.15.0 milestone May 20, 2022
@github-actions
Copy link

This functionality has been released in v4.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit
Copy link
Contributor

Related:

@ewbankkit ewbankkit mentioned this pull request May 20, 2022
Closed
@anGie44 anGie44 mentioned this pull request May 23, 2022
Merged
@ewbankkit ewbankkit mentioned this pull request Jun 2, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
service/networkmanager Issues and PRs that pertain to the networkmanager service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zhelding @ewbankkit @gdavison