-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/provider: Initial goreleaser configuration and CI workflow #14033
Conversation
Reference: #8988 Reference: https://www.terraform.io/docs/registry/providers/publishing.html Going forward, the Terraform Provider release process for the Terraform Registry will recommend `goreleaser` for all providers, including the official ones released via a separate process today. Given this decision is now more final, we can begin the process of using this tool for CI. In the future, we can also support nightly builds and later releases via the new GitHub release process. For now though, we leverage it just to verify codebase cross-compilation for all platforms that will be supported after the upcoming 3.0.0 release.
Increase timeout to 1 hour to match GitHub Actions, reduce parallelism to try and reduce CPU contention.
.goreleaser.yml
Outdated
builds: | ||
- binary: '{{ .ProjectName }}_{{ .Version }}' | ||
env: | ||
- CGO_ENABLED=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if go mod download
does anything that this may affect, but you might want to move it to the top-level env
section, so that any other go
commands outside of builds
can pick it up too.
…view Reference: #14033 (review) Also let's try again with build concurrency enabled in the workflow.
Thanks, @radeksimko! Adjusted per your recommendations. Also going to see if re-enabling build concurrency is a good or bad idea, since the timeout is now fixed to match GitHub Actions'. |
This has been released in version 2.70.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #8988
Reference: https://www.terraform.io/docs/registry/providers/publishing.html
Release note for CHANGELOG:
Going forward, the Terraform Provider release process for the Terraform Registry will recommend
goreleaser
for all providers, including the official ones released via a separate process today. Given this decision is now more final, we can begin the process of using this tool for CI. In the future, we can also support nightly builds and later releases via the new GitHub release process. For now though, we leverage it just to verify codebase cross-compilation for all platforms that will be supported after the upcoming 3.0.0 release.Output from acceptance testing: N/A (CI testing)