inspector: Add support for SNS subscriptions #26334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
This squashed commit contains the following implementation steps: - Fill out resource schema - Add expand functions to Create function - Add Subscription finder function - Add flatten function to Read function - Add Update function calls - Add passing acceptance tests - Run terrafmt - Add documentation
ewbankkit
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccInspectorAssessmentTemplate_' PKG=inspector ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/inspector/... -v -count 1 -parallel 2 -run=TestAccInspectorAssessmentTemplate_ -timeout 180m
=== RUN TestAccInspectorAssessmentTemplate_basic
=== PAUSE TestAccInspectorAssessmentTemplate_basic
=== RUN TestAccInspectorAssessmentTemplate_disappears
=== PAUSE TestAccInspectorAssessmentTemplate_disappears
=== RUN TestAccInspectorAssessmentTemplate_tags
=== PAUSE TestAccInspectorAssessmentTemplate_tags
=== RUN TestAccInspectorAssessmentTemplate_eventSubscription
=== PAUSE TestAccInspectorAssessmentTemplate_eventSubscription
=== CONT TestAccInspectorAssessmentTemplate_basic
=== CONT TestAccInspectorAssessmentTemplate_tags
--- PASS: TestAccInspectorAssessmentTemplate_basic (23.29s)
=== CONT TestAccInspectorAssessmentTemplate_eventSubscription
--- PASS: TestAccInspectorAssessmentTemplate_tags (67.62s)
=== CONT TestAccInspectorAssessmentTemplate_disappears
--- PASS: TestAccInspectorAssessmentTemplate_eventSubscription (58.09s)
--- PASS: TestAccInspectorAssessmentTemplate_disappears (17.57s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/inspector 90.237s
|
This functionality has been released in v4.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to enable SNS topic subscriptions to specific assessment template events.
Supersedes #12261.
Resolves #843.
Community Note
Output from acceptance testing: