Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws_inspector_assessment_template ability to send findings to SNS topic. #843

Closed
hashibot opened this issue Jun 13, 2017 · 13 comments · Fixed by #26334
Closed

Aws_inspector_assessment_template ability to send findings to SNS topic. #843

hashibot opened this issue Jun 13, 2017 · 13 comments · Fixed by #26334
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/inspector Issues and PRs that pertain to the inspector service.
Milestone

Comments

@hashibot
Copy link

This issue was originally opened by @reliam as hashicorp/terraform#15238. It was migrated here as part of the provider split. The original body of the issue is below.


Hello!

When configuring AWS Inspector with Terraform, I noticed the feature to send findings to SNS is unavailable. Has this yet to make its way into terraform?

Thank you for any insight into this issue!

Terraform Version

➜ terraform --version
Terraform v0.9.8

Affected Resource(s)

  • aws_inspector_assessment_template

Terraform Configuration Files

Debug Output

Panic Output

Expected Behavior

Ability to configure Inspector to send findings to a SNS topic

Actual Behavior

Feature currently unavailable

Steps to Reproduce

Login to AWS Console > Inspector > Assessment Templates
Select an assessment template > SNS Topics

Per https://www.terraform.io/docs/providers/aws/r/inspector_resource_group.html, the argument to set an SNS topic is unavailable.

Important Factoids

The use case is to have Inspector send its findings to SNS, which is subscribed to by a Lambda function that parses, normalizes and sends data to a log aggregator.

References

@hashibot hashibot added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 13, 2017
@thomasbiddle
Copy link
Contributor

I believe this functionality is lacking as well.

@rajholla
Copy link
Contributor

rajholla commented Nov 2, 2017

Any tentative date to enhance "inspector_assessment_template" to support SNS ?

@bflad bflad added the service/inspector Issues and PRs that pertain to the inspector service. label Jan 28, 2018
@Constantin07
Copy link

Are there any plans to address this one ?

@e-moshaya
Copy link

Can't believe this has been open since June 2017...

@FnTm
Copy link
Contributor

FnTm commented Jan 22, 2020

The corresponding CLI calls for template creation don't actually expose a way to do this.
The way it's handled is by a call to subscribe-to-event which would turn this issue into one requiring the creation of a new resource instead of just modifying an existing one.

@FnTm
Copy link
Contributor

FnTm commented Jan 27, 2020

Just to add a bit more to this - it looks like unsubscribe-from-event is the opposite of subscribe-to-event. This should be a fairly straightforward thing to implement. I don't think I'll have the time to do it myself in the next 2-3 months, but I might try to find some afterwards if no-one else starts addressing this.

@fedecz
Copy link

fedecz commented Mar 4, 2020

I think I've got it working, submitting a PR shortly

@fedecz
Copy link

fedecz commented Mar 5, 2020

submitted PR #12261 . I'd appreciate if you thumb'd it up for visibility 👍

@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Feb 24, 2022
@FnTm
Copy link
Contributor

FnTm commented Feb 26, 2022

#12261 would still be nice to get merged. Commenting to un-stale.

@github-actions github-actions bot removed the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Feb 26, 2022
@kpucynski
Copy link

Is this on the roadmap? Any updates?
I need this now ;)

@github-actions
Copy link

This functionality has been released in v4.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/inspector Issues and PRs that pertain to the inspector service.
Projects
None yet
10 participants