resource/aws_inspector_assessment_target: subscribe-to-event #3957

s-maj · 2018-03-28T18:52:27Z

Based on PR: hashicorp/terraform#13534
Fixes: #843
Fixed tests and added retries to avoid SNS Topic policy eventual consistency issues.

make testacc TEST=./aws TESTARGS='-run=TestAccAWSInspectorTemplate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSInspectorTemplate -timeout 120m
=== RUN   TestAccAWSInspectorTemplateEventSubscriptions_basic
--- PASS: TestAccAWSInspectorTemplateEventSubscriptions_basic (47.16s)
=== RUN   TestAccAWSInspectorTemplateEventSubscriptions_update
--- PASS: TestAccAWSInspectorTemplateEventSubscriptions_update (128.64s)
=== RUN   TestAccAWSInspectorTemplate_basic
--- PASS: TestAccAWSInspectorTemplate_basic (57.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	233.018s

vpadronblanco · 2018-04-09T19:33:59Z

Can we get this merged? I have use of this as well

joaquinrinaudo-olx · 2018-05-28T10:17:17Z

+1: We also need SNS subscription to Inspector.

humayunjamal · 2018-06-19T08:30:18Z

+1: Please merge

gileshinchcliff · 2018-08-14T08:54:33Z

Any update on this?

s-maj · 2018-08-27T17:33:25Z

Hi @bflad!
Would be possible to merge this or something is still missing here?

bribot0225 · 2018-08-29T18:17:29Z

Would love to see this merged as well.

paultyng · 2018-11-02T13:03:00Z

aws/resource_aws_inspector_assessment_event_subscriptions_template_test.go

+	return fmt.Sprintf(testAccAWSInspectorTemplateAssessmentConfig, "", "")
+}
+
+func testAccAWSInspectorTemplateAssessmentConfigTwoEventSubscritpions() string {


this function name is misspelled (Subscritpions), should probably be testAccAWSInspectorTemplateAssessmentConfigTwoEventSubscriptions

paultyng · 2018-11-02T13:04:42Z

aws/resource_aws_inspector_assessment_event_subscriptions_template_test.go

+  %s
+}`
+
+var AWSInspectorTwoEventSubscriptions = `


these don't need to be exported

paultyng · 2018-11-02T13:06:11Z

aws/resource_aws_inspector_assessment_template.go

+						"event": {
+							Type:         schema.TypeString,
+							Required:     true,
+							ValidateFunc: validateSubscribeToEvent,


please use validation.StringInSlice instead

paultyng · 2018-11-02T13:07:02Z

aws/resource_aws_inspector_assessment_template.go

@@ -119,3 +228,68 @@ func resourceAwsInspectorAssessmentTemplateDelete(d *schema.ResourceData, meta i

 	return nil
 }
+
+// validateSubscribeToEvent validates the string is a known keyword


can remove this once you swap validation to validation.StringInSlice

paultyng · 2018-11-02T13:07:30Z

website/docs/r/inspector_assessment_target.html.markdown


 Provides a Inspector assessment target

 ## Example Usage

-```hcl


this should stay, the language of the example is hcl

paultyng · 2018-11-02T13:10:08Z

aws/resource_aws_inspector_assessment_template.go

+						},
+					},
+				},
+				Set: func(v interface{}) int {


This is unnecessary, the hash by default will contain all the keys.

paultyng · 2018-11-02T13:12:48Z

aws/resource_aws_inspector_assessment_template.go

+						},
+						"topic_arn": {
+							Type:     schema.TypeString,
+							Required: true,


You can use ValidateFunc: validateArn here (see https://github.com/terraform-providers/terraform-provider-aws/blob/b797d11058d9293aa9cd95eb54c39883d5813756/aws/validators.go#L470:6)

paultyng · 2018-11-02T13:27:02Z

aws/resource_aws_inspector_assessment_template.go

+}
+
+// substractEventSubscriptions return elements of 'a' which are not contained in 'b'
+func substractEventSubscriptions(a []map[string]interface{}, b []map[string]interface{}) (result []map[string]interface{}) {


schema.Set has a Difference function that would make this cleaner, can probably eliminate it

paultyng · 2018-11-02T13:27:54Z

aws/resource_aws_inspector_assessment_template.go

+	return
+}
+
+func containsEventSubscription(s []map[string]interface{}, e map[string]interface{}) bool {


schema.Set has a Contains function that would make this cleaner, can probably eliminate it

CaseyLabs · 2018-12-03T23:05:22Z

Hi there, what's the status of this merge request? I've just ran into this issue as well, where I'm unable to associate an AWS Inspector template with an SNS topic via Terraform.

someeodtech · 2019-02-22T12:50:57Z

Any status on resolving conflicts & finishing this merge?

frederiksf · 2019-03-19T10:42:33Z

Any updates here?

chilliblast · 2019-04-26T15:45:24Z

Hi all

Is there any update on this as I have a pending need for this functionality also.

Thanks

rafaelmagu · 2019-05-30T02:19:54Z

@s-maj will you continue working on this branch or has this PR been abandoned?

dharada1 · 2019-06-14T03:20:46Z

we need this

joshpavel · 2019-06-14T13:07:59Z

FYI, my workaround:

resource "null_resource" "inspector_sns" {

  provisioner "local-exec" {
    command = "aws --region ${data.aws_region.current.name} inspector subscribe-to-event --resource-arn ${aws_inspector_assessment_template.inspector_assessment_template.arn} --event FINDING_REPORTED --topic-arn ${aws_sns_topic.inspector.arn}"
  }

  depends_on = [
    "aws_lambda_function.inspector_reports",
    "aws_sns_topic.inspector"
  ]
}

bflad · 2019-12-20T18:00:39Z

Hi folks 👋 Since there has been no activity with this pull request, especially in response to the requested changes from a year ago and the current merge conflicts, we are going to close this. If the original author or a community member has the ambition to continue working on this, please submit a new pull request and the maintainers will take a fresh look. Thanks.

fedecz · 2020-03-05T21:09:34Z

I submitted PR #12261 to address this issue. I'd appreciate if you thumb'd it up for visibility. Thanks 👍

ghost · 2020-03-06T14:50:18Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

AWS Inspector SNS subscription support

f5ea3a0

ghost added the size/L Managed by automation to categorize the size of a PR. label Mar 28, 2018

radeksimko added service/inspector Issues and PRs that pertain to the inspector service. enhancement Requests to existing resources that expand the functionality or scope. labels Mar 29, 2018

s-maj changed the title ~~AWS Inspector subscribe-to-event~~ resource/aws_inspector_assessment_target: subscribe-to-event May 18, 2018

paultyng suggested changes Nov 2, 2018

View reviewed changes

bflad closed this Dec 20, 2019

fedecz mentioned this pull request Mar 4, 2020

AWS Inspector SNS subscription support #12261

Closed

ghost locked and limited conversation to collaborators Mar 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resource/aws_inspector_assessment_target: subscribe-to-event #3957

resource/aws_inspector_assessment_target: subscribe-to-event #3957

s-maj commented Mar 28, 2018

vpadronblanco commented Apr 9, 2018 •

edited

Loading

joaquinrinaudo-olx commented May 28, 2018

humayunjamal commented Jun 19, 2018

gileshinchcliff commented Aug 14, 2018

s-maj commented Aug 27, 2018

bribot0225 commented Aug 29, 2018

paultyng Nov 2, 2018

paultyng Nov 2, 2018

paultyng Nov 2, 2018

paultyng Nov 2, 2018

paultyng Nov 2, 2018

paultyng Nov 2, 2018

paultyng Nov 2, 2018

paultyng Nov 2, 2018

paultyng Nov 2, 2018

CaseyLabs commented Dec 3, 2018

someeodtech commented Feb 22, 2019

frederiksf commented Mar 19, 2019

chilliblast commented Apr 26, 2019

rafaelmagu commented May 30, 2019

dharada1 commented Jun 14, 2019

joshpavel commented Jun 14, 2019 •

edited

Loading

bflad commented Dec 20, 2019

fedecz commented Mar 5, 2020

ghost commented Mar 6, 2020

resource/aws_inspector_assessment_target: subscribe-to-event #3957

resource/aws_inspector_assessment_target: subscribe-to-event #3957

Conversation

s-maj commented Mar 28, 2018

vpadronblanco commented Apr 9, 2018 • edited Loading

joaquinrinaudo-olx commented May 28, 2018

humayunjamal commented Jun 19, 2018

gileshinchcliff commented Aug 14, 2018

s-maj commented Aug 27, 2018

bribot0225 commented Aug 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CaseyLabs commented Dec 3, 2018

someeodtech commented Feb 22, 2019

frederiksf commented Mar 19, 2019

chilliblast commented Apr 26, 2019

rafaelmagu commented May 30, 2019

dharada1 commented Jun 14, 2019

joshpavel commented Jun 14, 2019 • edited Loading

bflad commented Dec 20, 2019

fedecz commented Mar 5, 2020

ghost commented Mar 6, 2020

vpadronblanco commented Apr 9, 2018 •

edited

Loading

joshpavel commented Jun 14, 2019 •

edited

Loading