Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EC2-Classic retirement phase 1: Resource and attribute deprecation #26427

Merged
merged 13 commits into from
Aug 24, 2022
Merged

EC2-Classic retirement phase 1: Resource and attribute deprecation #26427

merged 13 commits into from
Aug 24, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 22, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23625.

With the retirement of EC2-Classic various resources and resource attributes are now deprecated.

% make testacc TESTARGS='-run=TestAccVPC_basic\|TestAccVPCPeeringConnection_basic\|TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount\|TestAccVPCPeeringConnectionOptions_basic' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPC_basic\|TestAccVPCPeeringConnection_basic\|TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount\|TestAccVPCPeeringConnectionOptions_basic -timeout 180m
=== RUN   TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount
=== PAUSE TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount
=== RUN   TestAccVPCPeeringConnectionOptions_basic
=== PAUSE TestAccVPCPeeringConnectionOptions_basic
=== RUN   TestAccVPCPeeringConnection_basic
=== PAUSE TestAccVPCPeeringConnection_basic
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== CONT  TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount
=== CONT  TestAccVPCPeeringConnection_basic
--- PASS: TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount (22.17s)
=== CONT  TestAccVPCPeeringConnectionOptions_basic
--- PASS: TestAccVPCPeeringConnection_basic (22.25s)
=== CONT  TestAccVPC_basic
--- PASS: TestAccVPC_basic (20.20s)
--- PASS: TestAccVPCPeeringConnectionOptions_basic (46.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	72.554s
% make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_basic' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingLaunchConfiguration_basic -timeout 180m
=== RUN   TestAccAutoScalingLaunchConfiguration_basic
=== PAUSE TestAccAutoScalingLaunchConfiguration_basic
=== CONT  TestAccAutoScalingLaunchConfiguration_basic
--- PASS: TestAccAutoScalingLaunchConfiguration_basic (33.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	38.181s
% make testacc TESTARGS='-run=TestAccRedshiftCluster_basic' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2  -run=TestAccRedshiftCluster_basic -timeout 180m
=== RUN   TestAccRedshiftCluster_basic
=== PAUSE TestAccRedshiftCluster_basic
=== CONT  TestAccRedshiftCluster_basic
--- PASS: TestAccRedshiftCluster_basic (282.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	286.078s
% make testacc TESTARGS='-run=TestAccElastiCacheCluster_Engine_memcached' PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2  -run=TestAccElastiCacheCluster_Engine_memcached -timeout 180m
=== RUN   TestAccElastiCacheCluster_Engine_memcached
=== PAUSE TestAccElastiCacheCluster_Engine_memcached
=== CONT  TestAccElastiCacheCluster_Engine_memcached
--- PASS: TestAccElastiCacheCluster_Engine_memcached (495.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	499.820s
% make testacc TESTARGS='-run=TestAccRDSInstance_basic' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstance_basic -timeout 180m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_basic
--- PASS: TestAccRDSInstance_basic (582.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	596.692s

@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. labels Aug 22, 2022
@ewbankkit ewbankkit marked this pull request as draft August 22, 2022 16:19
ewbankkit added 12 commits August 22, 2022 12:21
@ewbankkit
Correct CHANGELOG file name.
9ea57fd
@ewbankkit
Fix typo.
d510ea5
@ewbankkit
r/aws_db_security_group: Document deprecation.
3334be4
@ewbankkit
r/aws_redshift_security_group: Deprecation notice.
2ccd23d
@ewbankkit
r/aws_elasticache_security_group: Deprecation notice.
12f8a8b
@ewbankkit
Correct location of deprecation notice in the documentation.
651fb92
@ewbankkit
r/aws_db_instance: Deprecate 'security_group_names'.
1296277
@ewbankkit
r/aws_redshift_cluster: Deprecate 'cluster_security_groups' attribute.
9e7efa6
@ewbankkit
r/aws_elasticache_cluster: Deprecate 'security_group_names'.
2df6a8c
@ewbankkit
r/aws_launch_configuration: Deprecate 'vpc_classic_link_id' and 'vpc_…
f0794a3 
…classic_link_security_groups'.
@ewbankkit
r/aws_vpc: Deprecate 'enable_classiclink' and 'enable_classiclink_dns…
76f3099 
…_support'.
@ewbankkit
r/aws_vpc_peering_connection(_accepter|_options): Deprecate 'allow_cl…
a131e68 
…assic_link_to_remote_vpc' and 'allow_vpc_to_remote_classic_link'.
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/elasticache Issues and PRs that pertain to the elasticache service. service/redshift Issues and PRs that pertain to the redshift service. service/vpc Issues and PRs that pertain to the vpc service. labels Aug 22, 2022
@ewbankkit ewbankkit marked this pull request as ready for review August 22, 2022 18:37
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Aug 22, 2022
@ewbankkit ewbankkit mentioned this pull request Aug 22, 2022
Closed
@YakDriver YakDriver self-assigned this Aug 23, 2022
YakDriver
YakDriver approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

% make testacc TESTARGS='-run=TestAccVPC_basic\|TestAccVPCPeeringConnection_basic\|TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount\|TestAccVPCPeeringConnectionOptions_basic' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPC_basic\|TestAccVPCPeeringConnection_basic\|TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount\|TestAccVPCPeeringConnectionOptions_basic -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.44.80
--- PASS: TestAccVPCPeeringConnection_basic (47.76s)
--- PASS: TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount (48.22s)
--- PASS: TestAccVPC_basic (42.51s)
--- PASS: TestAccVPCPeeringConnectionOptions_basic (84.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	133.794s
% make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_basic' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingLaunchConfiguration_basic -timeout 180m
--- PASS: TestAccAutoScalingLaunchConfiguration_basic (40.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	42.390s
% make testacc TESTARGS='-run=TestAccRedshiftCluster_basic' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2  -run=TestAccRedshiftCluster_basic -timeout 180m
--- PASS: TestAccRedshiftCluster_basic (261.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	263.158s
% make testacc TESTARGS='-run=TestAccElastiCacheCluster_Engine_memcached' PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2  -run=TestAccElastiCacheCluster_Engine_memcached -timeout 180m
--- PASS: TestAccElastiCacheCluster_Engine_memcached (526.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	527.818s

@ewbankkit ewbankkit merged commit d0dd19b into main Aug 24, 2022
@ewbankkit ewbankkit deleted the td-ec2-classic-retirement-phase1 branch August 24, 2022 12:58
@github-actions github-actions bot added this to the v4.28.0 milestone Aug 24, 2022
github-actions bot pushed a commit that referenced this pull request Aug 24, 2022
Update CHANGELOG.md for #26427
3f07e74
@github-actions
Copy link

This functionality has been released in v4.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Aug 29, 2022
Merged
@ewbankkit ewbankkit mentioned this pull request Sep 13, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/elasticache Issues and PRs that pertain to the elasticache service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. service/vpc Issues and PRs that pertain to the vpc service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @YakDriver