-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EC2-Classic retirement phase 2: Prevent creation of new EC2-Classic resources #26525
Conversation
…link_dns_support'.
…security_groups' is set.
…ity_group_names' is set.
…classic_link_id' or 'vpc_classic_link_security_groups' is set.
Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2EIP_basic\|TestAccEC2EIP_disappears' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2EIP_basic\|TestAccEC2EIP_disappears -timeout 180m === RUN TestAccEC2EIP_basic === PAUSE TestAccEC2EIP_basic === RUN TestAccEC2EIP_disappears === PAUSE TestAccEC2EIP_disappears === CONT TestAccEC2EIP_basic === CONT TestAccEC2EIP_disappears --- PASS: TestAccEC2EIP_disappears (15.14s) --- PASS: TestAccEC2EIP_basic (19.27s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 23.304s
Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2EIP_tags' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2EIP_tags -timeout 180m === RUN TestAccEC2EIP_tags === PAUSE TestAccEC2EIP_tags === CONT TestAccEC2EIP_tags --- PASS: TestAccEC2EIP_tags (38.00s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 42.212s
Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2EIPAssociation_instance' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2EIPAssociation_instance -timeout 180m === RUN TestAccEC2EIPAssociation_instance === PAUSE TestAccEC2EIPAssociation_instance === CONT TestAccEC2EIPAssociation_instance --- PASS: TestAccEC2EIPAssociation_instance (130.78s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 134.833s
Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2EIPAssociation_basic' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2EIPAssociation_basic -timeout 180m === RUN TestAccEC2EIPAssociation_basic === PAUSE TestAccEC2EIPAssociation_basic === CONT TestAccEC2EIPAssociation_basic --- PASS: TestAccEC2EIPAssociation_basic (122.68s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 128.914s
Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2EIPAssociation_' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2EIPAssociation_ -timeout 180m === RUN TestAccEC2EIPAssociation_basic === PAUSE TestAccEC2EIPAssociation_basic === RUN TestAccEC2EIPAssociation_disappears === PAUSE TestAccEC2EIPAssociation_disappears === RUN TestAccEC2EIPAssociation_instance === PAUSE TestAccEC2EIPAssociation_instance === RUN TestAccEC2EIPAssociation_networkInterface === PAUSE TestAccEC2EIPAssociation_networkInterface === RUN TestAccEC2EIPAssociation_spotInstance === PAUSE TestAccEC2EIPAssociation_spotInstance === CONT TestAccEC2EIPAssociation_basic === CONT TestAccEC2EIPAssociation_networkInterface --- PASS: TestAccEC2EIPAssociation_networkInterface (29.97s) === CONT TestAccEC2EIPAssociation_spotInstance --- PASS: TestAccEC2EIPAssociation_basic (106.88s) === CONT TestAccEC2EIPAssociation_instance --- PASS: TestAccEC2EIPAssociation_spotInstance (79.53s) === CONT TestAccEC2EIPAssociation_disappears --- PASS: TestAccEC2EIPAssociation_disappears (102.83s) --- PASS: TestAccEC2EIPAssociation_instance (122.24s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 234.821s
Acceptance test output: % AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccEC2EIPAssociation_ec2Classic' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2EIPAssociation_ec2Classic -timeout 180m === RUN TestAccEC2EIPAssociation_ec2Classic === PAUSE TestAccEC2EIPAssociation_ec2Classic === CONT TestAccEC2EIPAssociation_ec2Classic --- PASS: TestAccEC2EIPAssociation_ec2Classic (171.31s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 177.345s
Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2EIP_association' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2EIP_association -timeout 180m === RUN TestAccEC2EIP_association === PAUSE TestAccEC2EIP_association === CONT TestAccEC2EIP_association --- PASS: TestAccEC2EIP_association (202.66s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 208.711s
…lassicLinkDNSSupportOptionSet'.
…ssicLink options enabled.
…e if ClassicLink options enabled.
…ce if ClassicLink options enabled.
This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #23625.
Relates #26427.
With the retirement of EC2-Classic we are now preventing the creation of new EC2-Classic resources.
Output from acceptance testing: