Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add resource for aws_controltower_control #26990

Merged
merged 21 commits into from
Nov 11, 2022
Merged

add resource for aws_controltower_control #26990

merged 21 commits into from
Nov 11, 2022

Conversation

silvaalbert
Copy link
Contributor

@silvaalbert silvaalbert commented Sep 27, 2022 •
edited
Loading

Closes #26612
Dependent on #26975, #26978

References

Output from Acceptance Testing

$ TF_ACC=1 make testacc TESTS=TestAccControlTowerControl_serial PKG=controltower
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/controltower/... -v -count 1 -parallel 20 -run='TestAccControlTowerControl_serial'  -timeout 180m
=== RUN   TestAccControlTowerControl_serial
=== RUN   TestAccControlTowerControl_serial/ControlTowerControl
=== RUN   TestAccControlTowerControl_serial/ControlTowerControl/disappears
=== RUN   TestAccControlTowerControl_serial/ControlTowerControl/basic
--- PASS: TestAccControlTowerControl_serial (420.26s)
    --- PASS: TestAccControlTowerControl_serial/ControlTowerControl (420.26s)
        --- PASS: TestAccControlTowerControl_serial/ControlTowerControl/disappears (208.78s)
        --- PASS: TestAccControlTowerControl_serial/ControlTowerControl/basic (211.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/controltower	422.911s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Sep 27, 2022
@silvaalbert silvaalbert force-pushed the f-resource-controltower_control branch from a2df0ff to 3bdfd79 Compare September 27, 2022 21:07
@albsilv-aws
address ci findings
53f72d0 
address ci findings

address ci findings

address ci findings
@silvaalbert silvaalbert force-pushed the f-resource-controltower_control branch from 3bdfd79 to 53f72d0 Compare September 27, 2022 21:16
@silvaalbert silvaalbert marked this pull request as ready for review September 27, 2022 21:39
@github-actions github-actions bot added service/controltower Issues and PRs that pertain to the controltower service. and removed github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. generators Relates to code generators. client-connections Pertains to the AWS Client and service connections. labels Sep 29, 2022
@silvaalbert
Copy link
Contributor Author

This PR adds a resource for aws_controltower_control, as described in #26612

@mrwacky42
Copy link
Contributor

mrwacky42 commented Oct 11, 2022 •
edited
Loading

Amazing! I was just looking for this feature today.
What's the canonical source for the ARNs of the controls ?

@breathingdust breathingdust added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 11, 2022
@lossanarch
Copy link

Amazing! I was just looking for this feature today. What's the canonical source for the ARNs of the controls ?

They can be found here @mrwacky42
https://docs.aws.amazon.com/controltower/latest/userguide/control-identifiers.html

ewbankkit
ewbankkit approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccControlTowerControl_serial PKG=controltower
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/controltower/... -v -count 1 -parallel 20 -run='TestAccControlTowerControl_serial'  -timeout 180m
=== RUN   TestAccControlTowerControl_serial
=== RUN   TestAccControlTowerControl_serial/Control
=== RUN   TestAccControlTowerControl_serial/Control/basic
=== RUN   TestAccControlTowerControl_serial/Control/disappears
--- PASS: TestAccControlTowerControl_serial (440.40s)
    --- PASS: TestAccControlTowerControl_serial/Control (440.40s)
        --- PASS: TestAccControlTowerControl_serial/Control/basic (222.66s)
        --- PASS: TestAccControlTowerControl_serial/Control/disappears (217.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/controltower	445.133s

@ewbankkit
Copy link
Contributor

@silvaalbert Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 89e1fb5 into hashicorp:main Nov 11, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 11, 2022
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/controltower Issues and PRs that pertain to the controltower service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.40.0
Development

Successfully merging this pull request may close these issues.

Add resources for controling Control Tower Guardrails
7 participants
@silvaalbert @mrwacky42 @lossanarch @ewbankkit @breathingdust @justinretzolk @albsilv-aws