Add retry for MWAA CreateEnvironment on ValidationException

[dhegberg]

Handles scenario where IAM permission used in validation are slow to propagate.

Description

Introduce a retry on ValidationException & InternalServiceException

InternalServiceException is a general service 500 that can be retried.

ValidationException will include the case where an recently created IAM role is experiencing permission propagation delay. This retry is currently internal to the CreateEnvironment API, but will be removed in an upcoming release.

Relations

Relates #26429

References

Output from Acceptance Testing

Acceptance tests fail, but the same tests on the previous commit also fail.

Verified MWAA Environment creation does succeed. Tested triggering ValidationError and verified multiple retries occurred.

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mwaa/... -v -count 1 -parallel 20 -run='TestAccMWAAEnvironment_basic'  -timeout 180m
=== RUN   TestAccMWAAEnvironment_basic
=== PAUSE TestAccMWAAEnvironment_basic
=== CONT  TestAccMWAAEnvironment_basic
    environment_test.go:24: Failed state verification, resource with ID us-west-2 not found
--- FAIL: TestAccMWAAEnvironment_basic (2359.15s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	2359.221s
FAIL
make: *** [testacc] Error 1

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[dhegberg]

@breathingdust

Can you advise on the right use of isResourceTimeoutError as required by the Semgrep check?

If I'm interpreting correctly, it's used to trigger cleanup when the timeout occurs.

MWAA environments have a blocking status. If the Environment is in CREATING then DeleteEnvironment cannot be called.

Should the isResourceTimeoutError just return null (with a comment explaining that behavior)?

[ewbankkit]

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccMWAAEnvironment_' PKG=mwaa ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mwaa/... -v -count 1 -parallel 2  -run=TestAccMWAAEnvironment_ -timeout 360m
=== RUN   TestAccMWAAEnvironment_basic
=== PAUSE TestAccMWAAEnvironment_basic
=== RUN   TestAccMWAAEnvironment_disappears
=== PAUSE TestAccMWAAEnvironment_disappears
=== RUN   TestAccMWAAEnvironment_airflowOptions
=== PAUSE TestAccMWAAEnvironment_airflowOptions
=== RUN   TestAccMWAAEnvironment_log
=== PAUSE TestAccMWAAEnvironment_log
=== RUN   TestAccMWAAEnvironment_full
=== PAUSE TestAccMWAAEnvironment_full
=== RUN   TestAccMWAAEnvironment_pluginsS3ObjectVersion
=== PAUSE TestAccMWAAEnvironment_pluginsS3ObjectVersion
=== CONT  TestAccMWAAEnvironment_basic
=== CONT  TestAccMWAAEnvironment_log
--- PASS: TestAccMWAAEnvironment_basic (2314.28s)
=== CONT  TestAccMWAAEnvironment_airflowOptions
--- PASS: TestAccMWAAEnvironment_log (2990.47s)
=== CONT  TestAccMWAAEnvironment_disappears
--- PASS: TestAccMWAAEnvironment_disappears (2505.37s)
=== CONT  TestAccMWAAEnvironment_pluginsS3ObjectVersion
--- PASS: TestAccMWAAEnvironment_airflowOptions (3730.01s)
=== CONT  TestAccMWAAEnvironment_full
--- PASS: TestAccMWAAEnvironment_full (2338.81s)
--- PASS: TestAccMWAAEnvironment_pluginsS3ObjectVersion (3079.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	8580.178s

[ewbankkit]

@dhegberg Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.