[Bug]: AWS sso can not associate user to permission set and account

[AngeloGelmini]

Terraform Core Version

1.0.0

AWS Provider Version

4.34

Affected Resource(s)

// version used in 4.33
data "aws_identitystore_user" "users" {
  for_each          = toset(local.users[*].name)
  identity_store_id = tolist(data.aws_ssoadmin_instances.selected.identity_store_ids)[0]

  filter {
    attribute_path  = "UserName"
    attribute_value = each.value
  }
}
// with no deprecation given by 4.34
data "aws_identitystore_user" "users" {
  for_each          = toset(local.users[*].name)
  identity_store_id = tolist(data.aws_ssoadmin_instances.selected.identity_store_ids)[0]

  alternate_identifier {
    unique_attribute {
      attribute_path  = "UserName"
      attribute_value = each.value
    }
  }
}
resource "aws_ssoadmin_account_assignment" "users" {
  for_each           = {for val in local.users_privileges: replace("${val.name}-${val.account}-${val.permission}", " ", "_") => val}
  instance_arn       = tolist(data.aws_ssoadmin_instances.selected.arns)[0]
  permission_set_arn = data.aws_ssoadmin_permission_set.list[each.value.permission].arn
  principal_id       = data.aws_identitystore_user.users[each.value.name].user_id
  target_id          = local.accounts_by_name[each.value.account]
  principal_type     = "USER"
  target_type        = "AWS_ACCOUNT"
}

Expected Behavior

with provider 4.33 it associate the user to a permission set and account

Actual Behavior

With both version of aws_identitystore_user we have the same error:

Error: setting AWS SSO Identity Store User Data Source (936*****83c): external_ids.0.id: '' expected type 'bool', got unconvertible type 'string', value: 'b29******94'
  with data.aws_identitystore_user.users["name.surname@example.com"],
  on data.tf line 5, in data "aws_identitystore_user" "users":
   5: data "aws_identitystore_user" "users" {

Relevant Error/Panic Output Snippet

Error: setting AWS SSO Identity Store User Data Source (936*****83c): external_ids.0.id: '' expected type 'bool', got unconvertible type 'string', value: 'b29******94'
  with data.aws_identitystore_user.users["name.surname@example.com"],
  on data.tf line 5, in data "aws_identitystore_user" "users":
   5: data "aws_identitystore_user" "users" {

Terraform Configuration Files

[Container] 2022/10/07 08:50:50 Running command bash adf-build/helpers/terraform/adf_terraform.sh $TF_STAGE
Terraform v1.0.0
on linux_amd64
Your version of Terraform is out of date! The latest version
is 1.3.2. You can update by downloading from https://www.terraform.io/downloads.html
Terraform stage: plan
List of target regions: eu-west-1
List of target account: ****
Running terraform plan on account **** and region eu-west-1
Initializing the backend...
Successfully configured the backend "s3"! Terraform will automatically
use this backend unless the backend configuration changes.
Initializing provider plugins...
- Finding hashicorp/aws versions matching ">= 4.0.0"...
- Installing hashicorp/aws v4.34.0...
- Installed hashicorp/aws v4.34.0 (signed by HashiCorp)

Steps to Reproduce

• have AWS SSO
• have an external IDP (Azure)
• assegnate user to specific account and permission set

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

No response

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[bschaatsbergen]

Prepping a fix for this.

[ewbankkit]

Similar: #27145.

[github-actions]

This functionality has been released in v4.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.