Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect type on IdentityStore user resource / data source #27184

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Fix incorrect type on IdentityStore user resource / data source #27184

merged 2 commits into from
Oct 10, 2022

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Oct 10, 2022 •
edited
Loading

Description

Relations

Closes #27145
Closes #27144

References

Output from Acceptance Testing

% make testacc TESTS=TestAccIdentityStoreUserDataSource_\|TestAccIdentityStoreUser_ PKG=identitystore ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 2 -run='TestAccIdentityStoreUserDataSource_|TestAccIdentityStoreUser_'  -timeout 180m
=== RUN   TestAccIdentityStoreUserDataSource_basic
=== PAUSE TestAccIdentityStoreUserDataSource_basic
=== RUN   TestAccIdentityStoreUserDataSource_filterUserName
=== PAUSE TestAccIdentityStoreUserDataSource_filterUserName
=== RUN   TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== PAUSE TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== RUN   TestAccIdentityStoreUserDataSource_email
=== PAUSE TestAccIdentityStoreUserDataSource_email
=== RUN   TestAccIdentityStoreUserDataSource_userID
=== PAUSE TestAccIdentityStoreUserDataSource_userID
=== RUN   TestAccIdentityStoreUserDataSource_nonExistent
=== PAUSE TestAccIdentityStoreUserDataSource_nonExistent
=== RUN   TestAccIdentityStoreUserDataSource_userIdFilterMismatch
=== PAUSE TestAccIdentityStoreUserDataSource_userIdFilterMismatch
=== RUN   TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute
=== PAUSE TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute
=== RUN   TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId
=== PAUSE TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId
=== RUN   TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId
=== PAUSE TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId
=== RUN   TestAccIdentityStoreUser_basic
=== PAUSE TestAccIdentityStoreUser_basic
=== RUN   TestAccIdentityStoreUser_disappears
=== PAUSE TestAccIdentityStoreUser_disappears
=== RUN   TestAccIdentityStoreUser_Addresses
=== PAUSE TestAccIdentityStoreUser_Addresses
=== RUN   TestAccIdentityStoreUser_Emails
=== PAUSE TestAccIdentityStoreUser_Emails
=== RUN   TestAccIdentityStoreUser_Locale
=== PAUSE TestAccIdentityStoreUser_Locale
=== RUN   TestAccIdentityStoreUser_NameFamilyName
=== PAUSE TestAccIdentityStoreUser_NameFamilyName
=== RUN   TestAccIdentityStoreUser_NameFormatted
=== PAUSE TestAccIdentityStoreUser_NameFormatted
=== RUN   TestAccIdentityStoreUser_NameGivenName
=== PAUSE TestAccIdentityStoreUser_NameGivenName
=== RUN   TestAccIdentityStoreUser_NameHonorificPrefix
=== PAUSE TestAccIdentityStoreUser_NameHonorificPrefix
=== RUN   TestAccIdentityStoreUser_NameHonorificSuffix
=== PAUSE TestAccIdentityStoreUser_NameHonorificSuffix
=== RUN   TestAccIdentityStoreUser_NameMiddleName
=== PAUSE TestAccIdentityStoreUser_NameMiddleName
=== RUN   TestAccIdentityStoreUser_NickName
=== PAUSE TestAccIdentityStoreUser_NickName
=== RUN   TestAccIdentityStoreUser_PhoneNumbers
=== PAUSE TestAccIdentityStoreUser_PhoneNumbers
=== RUN   TestAccIdentityStoreUser_PreferredLanguage
=== PAUSE TestAccIdentityStoreUser_PreferredLanguage
=== RUN   TestAccIdentityStoreUser_ProfileURL
=== PAUSE TestAccIdentityStoreUser_ProfileURL
=== RUN   TestAccIdentityStoreUser_Timezone
=== PAUSE TestAccIdentityStoreUser_Timezone
=== RUN   TestAccIdentityStoreUser_Title
=== PAUSE TestAccIdentityStoreUser_Title
=== RUN   TestAccIdentityStoreUser_UserType
=== PAUSE TestAccIdentityStoreUser_UserType
=== CONT  TestAccIdentityStoreUserDataSource_basic
=== CONT  TestAccIdentityStoreUser_Title
--- PASS: TestAccIdentityStoreUserDataSource_basic (21.56s)
=== CONT  TestAccIdentityStoreUser_Emails
--- PASS: TestAccIdentityStoreUser_Title (55.46s)
=== CONT  TestAccIdentityStoreUser_Timezone
--- PASS: TestAccIdentityStoreUser_Emails (78.87s)
=== CONT  TestAccIdentityStoreUser_ProfileURL
--- PASS: TestAccIdentityStoreUser_Timezone (61.58s)
=== CONT  TestAccIdentityStoreUser_PreferredLanguage
--- PASS: TestAccIdentityStoreUser_ProfileURL (55.53s)
=== CONT  TestAccIdentityStoreUser_PhoneNumbers
--- PASS: TestAccIdentityStoreUser_PreferredLanguage (52.74s)
=== CONT  TestAccIdentityStoreUser_NickName
--- PASS: TestAccIdentityStoreUser_NickName (63.38s)
=== CONT  TestAccIdentityStoreUser_NameMiddleName
--- PASS: TestAccIdentityStoreUser_PhoneNumbers (83.77s)
=== CONT  TestAccIdentityStoreUser_NameHonorificSuffix
--- PASS: TestAccIdentityStoreUser_NameMiddleName (65.49s)
=== CONT  TestAccIdentityStoreUser_NameHonorificPrefix
--- PASS: TestAccIdentityStoreUser_NameHonorificSuffix (66.70s)
=== CONT  TestAccIdentityStoreUser_NameGivenName
--- PASS: TestAccIdentityStoreUser_NameHonorificPrefix (46.88s)
=== CONT  TestAccIdentityStoreUser_NameFormatted
--- PASS: TestAccIdentityStoreUser_NameGivenName (45.44s)
=== CONT  TestAccIdentityStoreUser_NameFamilyName
--- PASS: TestAccIdentityStoreUser_NameFamilyName (44.41s)
=== CONT  TestAccIdentityStoreUser_Locale
--- PASS: TestAccIdentityStoreUser_NameFormatted (71.21s)
=== CONT  TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute
--- PASS: TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute (2.13s)
=== CONT  TestAccIdentityStoreUser_Addresses
--- PASS: TestAccIdentityStoreUser_Locale (75.02s)
=== CONT  TestAccIdentityStoreUser_disappears
--- PASS: TestAccIdentityStoreUser_disappears (20.56s)
=== CONT  TestAccIdentityStoreUser_basic
--- PASS: TestAccIdentityStoreUser_Addresses (95.41s)
=== CONT  TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId
--- PASS: TestAccIdentityStoreUser_basic (25.99s)
=== CONT  TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId
--- PASS: TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId (12.43s)
=== CONT  TestAccIdentityStoreUserDataSource_userID
--- PASS: TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId (12.30s)
=== CONT  TestAccIdentityStoreUserDataSource_userIdFilterMismatch
--- PASS: TestAccIdentityStoreUserDataSource_userIdFilterMismatch (12.70s)
=== CONT  TestAccIdentityStoreUserDataSource_nonExistent
--- PASS: TestAccIdentityStoreUserDataSource_nonExistent (4.04s)
=== CONT  TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
--- PASS: TestAccIdentityStoreUserDataSource_userID (24.10s)
=== CONT  TestAccIdentityStoreUserDataSource_email
--- PASS: TestAccIdentityStoreUserDataSource_uniqueAttributeUserName (24.76s)
=== CONT  TestAccIdentityStoreUser_UserType
--- PASS: TestAccIdentityStoreUserDataSource_email (24.55s)
=== CONT  TestAccIdentityStoreUserDataSource_filterUserName
--- PASS: TestAccIdentityStoreUserDataSource_filterUserName (24.55s)
--- PASS: TestAccIdentityStoreUser_UserType (69.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	645.040s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/identitystore Issues and PRs that pertain to the identitystore service. labels Oct 10, 2022
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 10, 2022
@ewbankkit
Copy link
Contributor 

Terraform v1.0.9
on darwin_amd64

% make testacc TESTS=TestAccIdentityStoreUserDataSource_\|TestAccIdentityStoreUser_ PKG=identitystore ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 2 -run='TestAccIdentityStoreUserDataSource_|TestAccIdentityStoreUser_'  -timeout 180m
=== RUN   TestAccIdentityStoreUserDataSource_basic
=== PAUSE TestAccIdentityStoreUserDataSource_basic
=== RUN   TestAccIdentityStoreUserDataSource_filterUserName
=== PAUSE TestAccIdentityStoreUserDataSource_filterUserName
=== RUN   TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== PAUSE TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== RUN   TestAccIdentityStoreUserDataSource_email
=== PAUSE TestAccIdentityStoreUserDataSource_email
=== RUN   TestAccIdentityStoreUserDataSource_userID
=== PAUSE TestAccIdentityStoreUserDataSource_userID
=== RUN   TestAccIdentityStoreUserDataSource_nonExistent
=== PAUSE TestAccIdentityStoreUserDataSource_nonExistent
=== RUN   TestAccIdentityStoreUserDataSource_userIdFilterMismatch
=== PAUSE TestAccIdentityStoreUserDataSource_userIdFilterMismatch
=== RUN   TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute
=== PAUSE TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute
=== RUN   TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId
=== PAUSE TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId
=== RUN   TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId
=== PAUSE TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId
=== RUN   TestAccIdentityStoreUser_basic
=== PAUSE TestAccIdentityStoreUser_basic
=== RUN   TestAccIdentityStoreUser_disappears
=== PAUSE TestAccIdentityStoreUser_disappears
=== RUN   TestAccIdentityStoreUser_Addresses
=== PAUSE TestAccIdentityStoreUser_Addresses
=== RUN   TestAccIdentityStoreUser_Emails
=== PAUSE TestAccIdentityStoreUser_Emails
=== RUN   TestAccIdentityStoreUser_Locale
=== PAUSE TestAccIdentityStoreUser_Locale
=== RUN   TestAccIdentityStoreUser_NameFamilyName
=== PAUSE TestAccIdentityStoreUser_NameFamilyName
=== RUN   TestAccIdentityStoreUser_NameFormatted
=== PAUSE TestAccIdentityStoreUser_NameFormatted
=== RUN   TestAccIdentityStoreUser_NameGivenName
=== PAUSE TestAccIdentityStoreUser_NameGivenName
=== RUN   TestAccIdentityStoreUser_NameHonorificPrefix
=== PAUSE TestAccIdentityStoreUser_NameHonorificPrefix
=== RUN   TestAccIdentityStoreUser_NameHonorificSuffix
=== PAUSE TestAccIdentityStoreUser_NameHonorificSuffix
=== RUN   TestAccIdentityStoreUser_NameMiddleName
=== PAUSE TestAccIdentityStoreUser_NameMiddleName
=== RUN   TestAccIdentityStoreUser_NickName
=== PAUSE TestAccIdentityStoreUser_NickName
=== RUN   TestAccIdentityStoreUser_PhoneNumbers
=== PAUSE TestAccIdentityStoreUser_PhoneNumbers
=== RUN   TestAccIdentityStoreUser_PreferredLanguage
=== PAUSE TestAccIdentityStoreUser_PreferredLanguage
=== RUN   TestAccIdentityStoreUser_ProfileURL
=== PAUSE TestAccIdentityStoreUser_ProfileURL
=== RUN   TestAccIdentityStoreUser_Timezone
=== PAUSE TestAccIdentityStoreUser_Timezone
=== RUN   TestAccIdentityStoreUser_Title
=== PAUSE TestAccIdentityStoreUser_Title
=== RUN   TestAccIdentityStoreUser_UserType
=== PAUSE TestAccIdentityStoreUser_UserType
=== CONT  TestAccIdentityStoreUserDataSource_basic
=== CONT  TestAccIdentityStoreUser_Title
--- PASS: TestAccIdentityStoreUserDataSource_basic (21.56s)
=== CONT  TestAccIdentityStoreUser_Emails
--- PASS: TestAccIdentityStoreUser_Title (55.46s)
=== CONT  TestAccIdentityStoreUser_Timezone
--- PASS: TestAccIdentityStoreUser_Emails (78.87s)
=== CONT  TestAccIdentityStoreUser_ProfileURL
--- PASS: TestAccIdentityStoreUser_Timezone (61.58s)
=== CONT  TestAccIdentityStoreUser_PreferredLanguage
--- PASS: TestAccIdentityStoreUser_ProfileURL (55.53s)
=== CONT  TestAccIdentityStoreUser_PhoneNumbers
--- PASS: TestAccIdentityStoreUser_PreferredLanguage (52.74s)
=== CONT  TestAccIdentityStoreUser_NickName
--- PASS: TestAccIdentityStoreUser_NickName (63.38s)
=== CONT  TestAccIdentityStoreUser_NameMiddleName
--- PASS: TestAccIdentityStoreUser_PhoneNumbers (83.77s)
=== CONT  TestAccIdentityStoreUser_NameHonorificSuffix
--- PASS: TestAccIdentityStoreUser_NameMiddleName (65.49s)
=== CONT  TestAccIdentityStoreUser_NameHonorificPrefix
--- PASS: TestAccIdentityStoreUser_NameHonorificSuffix (66.70s)
=== CONT  TestAccIdentityStoreUser_NameGivenName
--- PASS: TestAccIdentityStoreUser_NameHonorificPrefix (46.88s)
=== CONT  TestAccIdentityStoreUser_NameFormatted
--- PASS: TestAccIdentityStoreUser_NameGivenName (45.44s)
=== CONT  TestAccIdentityStoreUser_NameFamilyName
--- PASS: TestAccIdentityStoreUser_NameFamilyName (44.41s)
=== CONT  TestAccIdentityStoreUser_Locale
--- PASS: TestAccIdentityStoreUser_NameFormatted (71.21s)
=== CONT  TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute
--- PASS: TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute (2.13s)
=== CONT  TestAccIdentityStoreUser_Addresses
--- PASS: TestAccIdentityStoreUser_Locale (75.02s)
=== CONT  TestAccIdentityStoreUser_disappears
--- PASS: TestAccIdentityStoreUser_disappears (20.56s)
=== CONT  TestAccIdentityStoreUser_basic
--- PASS: TestAccIdentityStoreUser_Addresses (95.41s)
=== CONT  TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId
--- PASS: TestAccIdentityStoreUser_basic (25.99s)
=== CONT  TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId
--- PASS: TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId (12.43s)
=== CONT  TestAccIdentityStoreUserDataSource_userID
--- PASS: TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId (12.30s)
=== CONT  TestAccIdentityStoreUserDataSource_userIdFilterMismatch
--- PASS: TestAccIdentityStoreUserDataSource_userIdFilterMismatch (12.70s)
=== CONT  TestAccIdentityStoreUserDataSource_nonExistent
--- PASS: TestAccIdentityStoreUserDataSource_nonExistent (4.04s)
=== CONT  TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
--- PASS: TestAccIdentityStoreUserDataSource_userID (24.10s)
=== CONT  TestAccIdentityStoreUserDataSource_email
--- PASS: TestAccIdentityStoreUserDataSource_uniqueAttributeUserName (24.76s)
=== CONT  TestAccIdentityStoreUser_UserType
--- PASS: TestAccIdentityStoreUserDataSource_email (24.55s)
=== CONT  TestAccIdentityStoreUserDataSource_filterUserName
--- PASS: TestAccIdentityStoreUserDataSource_filterUserName (24.55s)
--- PASS: TestAccIdentityStoreUser_UserType (69.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	645.040s

ewbankkit
ewbankkit approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit dc3534d into hashicorp:main Oct 10, 2022
@github-actions github-actions bot added this to the v4.35.0 milestone Oct 10, 2022
@bschaatsbergen bschaatsbergen deleted the b/fix-type branch October 10, 2022 21:01
@bschaatsbergen bschaatsbergen mentioned this pull request Oct 10, 2022
Merged
@ewbankkit ewbankkit mentioned this pull request Oct 12, 2022
Merged
@github-actions
Copy link

This functionality has been released in v4.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/identitystore Issues and PRs that pertain to the identitystore service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.35.0
2 participants
@bschaatsbergen @ewbankkit