Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support lakeformation data filters #27677

Closed
kazdy opened this issue Nov 7, 2022 · 3 comments · Fixed by #36264
Closed

[Enhancement]: Support lakeformation data filters #27677

kazdy opened this issue Nov 7, 2022 · 3 comments · Fixed by #36264
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. new-resource Introduces a new resource. service/lakeformation Issues and PRs that pertain to the lakeformation service.
Milestone

Comments

@kazdy
Copy link

kazdy commented Nov 7, 2022

Description

Lake Formation Data Filters have been introduced some time ago and are not yet supported by terraform.

Data Filters will allow users to specify row level permissions to data governed by lakeformation.

Affected Resource(s) and/or Data Source(s)

aws_lakeformation_permissions
[new] aws_lakeformation_data_filter

Potential Terraform Configuration

resource "aws_lakeformation_data_filter" "example" {
    column_names = ["col_a", "col_b"]
    column_wild_card = "*"
    database_name = "example_database"
    name = "example_filter_name"
    row_filter = "col_a = 'example'"
    table_catalog_id = 123456
    table_name = "example_table"
}

resource "aws_lakeformation_permissions" "test" {
  principal   = aws_iam_role.sales_role.arn
  permissions = ["DESCRIBE"]

  data_filter =  aws_lakeformation_data_filter.example
}

References

https://docs.aws.amazon.com/lake-formation/latest/dg/data-filters-about.html
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/lakeformation#Client.CreateDataCellsFilter
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lakeformation-datacellsfilter.html

Would you like to implement a fix?

No response

@kazdy kazdy added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Nov 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/lakeformation Issues and PRs that pertain to the lakeformation service. label Nov 7, 2022
@justinretzolk justinretzolk added new-resource Introduces a new resource. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 7, 2022
@johnsonaj johnsonaj self-assigned this Mar 6, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 6, 2024
@github-actions github-actions bot added this to the v5.41.0 milestone Mar 11, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 14, 2024
Copy link

This functionality has been released in v5.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. new-resource Introduces a new resource. service/lakeformation Issues and PRs that pertain to the lakeformation service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants