Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdt-lakeformation-data-cells-filter #27893

Closed
wants to merge 1 commit into from
Closed

fdt-lakeformation-data-cells-filter #27893

wants to merge 1 commit into from

Conversation

vwightman
Copy link

Description

Add the resource Data Cells Filter to Lake Formation

Adds acceptance testing and website documentation for the resource.

Does not add a Data Source for Data Cells Filter. Concerns with the lack of an individual "Get" API for Data Cells Filter. Forced to use a List API + iteration to retrieve Data Cells Filter attributes. Potential for performance issues due to this gap in API capability.

This PR does not update permissions to allow permissions to apply to Data Cells Filter. That would be too much change in 1 PR. But that is next.

Relations

Relates #27677
Relates #26687
Relates hashicorp/terraform-provider-awscc#719

References

Output from Acceptance Testing

PS C:\Users\x\workspace\terraform-provider-aws> go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestAccLakeFormation_' -timeout 60m
=== RUN   TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/database
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/dataLocation
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/lfTag
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/lfTagPolicy
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/table
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/tableWithColumns
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/basic
=== RUN   TestAccLakeFormation_serial/PermissionsTable
=== RUN   TestAccLakeFormation_serial/PermissionsTable/selectOnly
=== RUN   TestAccLakeFormation_serial/PermissionsTable/selectPlus
=== RUN   TestAccLakeFormation_serial/PermissionsTable/wildcardNoSelect
=== RUN   TestAccLakeFormation_serial/PermissionsTable/wildcardSelectPlus
=== RUN   TestAccLakeFormation_serial/PermissionsTable/basic
=== RUN   TestAccLakeFormation_serial/PermissionsTable/multipleRoles
=== RUN   TestAccLakeFormation_serial/PermissionsTable/wildcardSelectOnly
=== RUN   TestAccLakeFormation_serial/PermissionsTable/iamAllowed
=== RUN   TestAccLakeFormation_serial/PermissionsTable/implicit
=== RUN   TestAccLakeFormation_serial/PermissionsTableWithColumns
=== RUN   TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardExcludedColumns
=== RUN   TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectOnly
=== RUN   TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectPlus
=== RUN   TestAccLakeFormation_serial/PermissionsTableWithColumns/basic
=== RUN   TestAccLakeFormation_serial/PermissionsTableWithColumns/implicit
=== RUN   TestAccLakeFormation_serial/LFTags
=== RUN   TestAccLakeFormation_serial/LFTags/basic
=== RUN   TestAccLakeFormation_serial/LFTags/disappears
=== RUN   TestAccLakeFormation_serial/LFTags/values
=== RUN   TestAccLakeFormation_serial/ResourceLFTags
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/table
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/tableWithColumns
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/basic
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/database
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/databaseMultiple
=== RUN   TestAccLakeFormation_serial/DataCellsFilter
=== RUN   TestAccLakeFormation_serial/DataCellsFilter/inludeColumns
=== RUN   TestAccLakeFormation_serial/DataCellsFilter/excludeColumns
=== RUN   TestAccLakeFormation_serial/DataCellsFilter/allRowsExcludeColumns
=== RUN   TestAccLakeFormation_serial/DataCellsFilter/basic
=== RUN   TestAccLakeFormation_serial/DataCellsFilter/disappears
=== RUN   TestAccLakeFormation_serial/DataLakeSettings
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/basic
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/dataSource
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/disappears
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/withoutCatalogId
=== RUN   TestAccLakeFormation_serial/PermissionsBasic
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/databaseMultiple
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/dataLocation
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/disappears
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/lfTag
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/lfTagPolicy
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/basic
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/database
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/databaseIAMAllowed
--- PASS: TestAccLakeFormation_serial (1418.60s)
    --- PASS: TestAccLakeFormation_serial/PermissionsDataSource (210.67s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/database (30.98s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/dataLocation (31.49s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/lfTag (31.71s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/lfTagPolicy (28.66s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/table (27.96s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/tableWithColumns (30.47s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/basic (29.41s)
    --- PASS: TestAccLakeFormation_serial/PermissionsTable (281.78s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/selectOnly (29.44s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/selectPlus (29.24s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/wildcardNoSelect (26.47s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/wildcardSelectPlus (29.58s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/basic (30.81s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/multipleRoles (29.46s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/wildcardSelectOnly (28.99s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/iamAllowed (47.95s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/implicit (29.85s)
    --- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns (195.88s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardExcludedColumns (29.85s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectOnly (29.84s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectPlus (29.68s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/basic (76.52s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/implicit (29.99s)
    --- PASS: TestAccLakeFormation_serial/LFTags (76.19s)
        --- PASS: TestAccLakeFormation_serial/LFTags/basic (19.10s)
        --- PASS: TestAccLakeFormation_serial/LFTags/disappears (19.26s)
        --- PASS: TestAccLakeFormation_serial/LFTags/values (37.83s)
    --- PASS: TestAccLakeFormation_serial/ResourceLFTags (162.93s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/table (37.09s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/tableWithColumns (37.61s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/basic (17.42s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/database (35.57s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/databaseMultiple (35.25s)
    --- PASS: TestAccLakeFormation_serial/DataCellsFilter (111.21s)
        --- PASS: TestAccLakeFormation_serial/DataCellsFilter/inludeColumns (23.87s)
        --- PASS: TestAccLakeFormation_serial/DataCellsFilter/excludeColumns (23.99s)
        --- PASS: TestAccLakeFormation_serial/DataCellsFilter/allRowsExcludeColumns (21.20s)
        --- PASS: TestAccLakeFormation_serial/DataCellsFilter/basic (23.12s)
        --- PASS: TestAccLakeFormation_serial/DataCellsFilter/disappears (19.02s)
    --- PASS: TestAccLakeFormation_serial/DataLakeSettings (75.14s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/basic (18.96s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/dataSource (20.51s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/disappears (16.74s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/withoutCatalogId (18.93s)
    --- PASS: TestAccLakeFormation_serial/PermissionsBasic (304.79s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/databaseMultiple (26.50s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/dataLocation (29.41s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/disappears (91.68s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/lfTag (25.96s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/lfTagPolicy (28.02s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/basic (28.13s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/database (28.21s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/databaseIAMAllowed (46.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation      1425.060s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. needs-triage Waiting for first response or review from a maintainer. service/lakeformation Issues and PRs that pertain to the lakeformation service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Nov 18, 2022
@breathingdust breathingdust added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 24, 2022
@vwightman vwightman closed this Dec 7, 2022
@vwightman vwightman deleted the f-lakeformation-data-cells-filter branch December 7, 2022 17:04
@github-actions
Copy link

github-actions bot commented Jan 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vwightman @breathingdust