-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for "single-outpost" outpost_mode and preferred_outpost_arn to elasticache #27934
feat: add support for "single-outpost" outpost_mode and preferred_outpost_arn to elasticache #27934
Conversation
…post_arn to elasticache
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @weizhangfd 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccElastiCacheCluster_Engine_redis\|TestAccElastiCacheCluster_outpost\|TestAccElastiCacheClusterDataSource_Data_basic' PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2 -run=TestAccElastiCacheCluster_Engine_redis\|TestAccElastiCacheCluster_outpost\|TestAccElastiCacheClusterDataSource_Data_basic -timeout 180m
=== RUN TestAccElastiCacheClusterDataSource_Data_basic
=== PAUSE TestAccElastiCacheClusterDataSource_Data_basic
=== RUN TestAccElastiCacheCluster_Engine_redis
=== PAUSE TestAccElastiCacheCluster_Engine_redis
=== RUN TestAccElastiCacheCluster_Engine_redis_v5
=== PAUSE TestAccElastiCacheCluster_Engine_redis_v5
=== RUN TestAccElastiCacheCluster_outpost_memcached
=== PAUSE TestAccElastiCacheCluster_outpost_memcached
=== RUN TestAccElastiCacheCluster_outpost_redis
=== PAUSE TestAccElastiCacheCluster_outpost_redis
=== RUN TestAccElastiCacheCluster_outpostID_memcached
=== PAUSE TestAccElastiCacheCluster_outpostID_memcached
=== RUN TestAccElastiCacheCluster_outpostID_redis
=== PAUSE TestAccElastiCacheCluster_outpostID_redis
=== CONT TestAccElastiCacheClusterDataSource_Data_basic
=== CONT TestAccElastiCacheCluster_outpost_redis
acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpost_redis (1.86s)
=== CONT TestAccElastiCacheCluster_Engine_redis_v5
--- PASS: TestAccElastiCacheClusterDataSource_Data_basic (520.98s)
=== CONT TestAccElastiCacheCluster_outpost_memcached
acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpost_memcached (0.52s)
=== CONT TestAccElastiCacheCluster_Engine_redis
--- PASS: TestAccElastiCacheCluster_Engine_redis_v5 (558.91s)
=== CONT TestAccElastiCacheCluster_outpostID_redis
acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpostID_redis (0.17s)
=== CONT TestAccElastiCacheCluster_outpostID_memcached
acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpostID_memcached (0.23s)
--- PASS: TestAccElastiCacheCluster_Engine_redis (524.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 1037.641s
@weizhangfd Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add Outpost support to
aws_elasticache_cluster
.Relations
Closes #18460
References
Output from Acceptance Testing
Unfortunately I don't have an outpost instance available to run all the acceptance tests in outpost mode, apologies. Could I please trouble you to help me running them? Please feel free to edit the code.