Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: resource/aws_security_group_rule: security_group_rule_id attribute was removed #28110

Open
aidanmelen opened this issue Nov 30, 2022 · 1 comment
Labels
bug Addresses a defect in current functionality. service/vpc Issues and PRs that pertain to the vpc service.

Comments

@aidanmelen
Copy link
Contributor

aidanmelen commented Nov 30, 2022

Terraform Core Version

latest

AWS Provider Version

= 4.40.0

Affected Resource(s)

aws_security_group_rule

Expected Behavior

resource has security_group_rule_id attribute

Actual Behavior

The security_group_rule_id attribute was removed from the resource for AWS provider versions >= 4.40.0. I get that a single rule resource can map to many EC2 sg rules; however, all of those rules should be related to the same security_group_id. Therefore, I would expect that attribute to be set whether the relationship between sg and sgrules is 1-to-1 or 1-to-n

Terraform Configuration Files

https://github.com/aidanmelen/terraform-aws-security-group-v2/tree/v2.1.1/examples/basic

Steps to Reproduce

create any aws_security_group_rule with the AWS provider versions >= 4.40.0 and it will not have the security_group_rule_id attribute

Debug Output

No response

Panic Output

No response

Important Factoids

It looks like @ewbankkit mistakenly removed this attribute with #27828. I am not sure what was suppose to be worked on in that issue because this does not seem to be AWS provider versions =< 4.39.0, at least not that I understand.

As a result, my tests are failing: https://github.com/aidanmelen/terraform-aws-security-group-v2/blob/v2.1.1/test/terraform_basic_test.log#L252-L307

References

No response

Would you like to implement a fix?

No

@aidanmelen aidanmelen added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Nov 30, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

aidanmelen added a commit to aidanmelen/terraform-aws-security-group-v2 that referenced this issue Dec 1, 2022
@ewbankkit ewbankkit added service/vpc Issues and PRs that pertain to the vpc service. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/vpc Issues and PRs that pertain to the vpc service.
Projects
None yet
Development

No branches or pull requests

2 participants