Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC support for Grafana workspaces #28308

Merged
merged 6 commits into from
Dec 13, 2022
Merged

Conversation

DrFaust92
Copy link
Collaborator

Description

Relations

Closes #28244

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccGrafana_serial/Workspace/vpc  PKG=grafana

--- PASS: TestAccGrafana_serial (758.78s)
    --- PASS: TestAccGrafana_serial/Workspace (758.78s)
        --- PASS: TestAccGrafana_serial/Workspace/vpc (758.78s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/grafana Issues and PRs that pertain to the grafana service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Dec 12, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 12, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review December 12, 2022 18:05
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 13, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGrafana_serial/Workspace/vpc\|TestAccGrafana_serial/Workspace/saml' PKG=grafana ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 3  -run=TestAccGrafana_serial/Workspace/vpc\|TestAccGrafana_serial/Workspace/saml -timeout 180m
=== RUN   TestAccGrafana_serial
=== RUN   TestAccGrafana_serial/Workspace
=== RUN   TestAccGrafana_serial/Workspace/saml
=== RUN   TestAccGrafana_serial/Workspace/vpc
--- PASS: TestAccGrafana_serial (906.03s)
    --- PASS: TestAccGrafana_serial/Workspace (906.03s)
        --- PASS: TestAccGrafana_serial/Workspace/saml (374.17s)
        --- PASS: TestAccGrafana_serial/Workspace/vpc (531.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/grafana	914.236s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e9ea507 into hashicorp:main Dec 13, 2022
@github-actions github-actions bot added this to the v4.47.0 milestone Dec 13, 2022
@github-actions
Copy link

This functionality has been released in v4.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Comment on lines +103 to +107
{
ResourceName: resourceName,
ImportState: true,
ImportStateVerify: true,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 New to provider code, hoping you could answer some questions for clarity. What does this do? I've been seeing it in tests and occasionally they have another test step after but as well. Also why if there's another step, is it always after this block?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/grafana Issues and PRs that pertain to the grafana service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: VPC support for Grafana workspaces
3 participants