-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPC support for Grafana workspaces #28308
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccGrafana_serial/Workspace/vpc\|TestAccGrafana_serial/Workspace/saml' PKG=grafana ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 3 -run=TestAccGrafana_serial/Workspace/vpc\|TestAccGrafana_serial/Workspace/saml -timeout 180m
=== RUN TestAccGrafana_serial
=== RUN TestAccGrafana_serial/Workspace
=== RUN TestAccGrafana_serial/Workspace/saml
=== RUN TestAccGrafana_serial/Workspace/vpc
--- PASS: TestAccGrafana_serial (906.03s)
--- PASS: TestAccGrafana_serial/Workspace (906.03s)
--- PASS: TestAccGrafana_serial/Workspace/saml (374.17s)
--- PASS: TestAccGrafana_serial/Workspace/vpc (531.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/grafana 914.236s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
{ | ||
ResourceName: resourceName, | ||
ImportState: true, | ||
ImportStateVerify: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 New to provider code, hoping you could answer some questions for clarity. What does this do? I've been seeing it in tests and occasionally they have another test step after but as well. Also why if there's another step, is it always after this block?
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #28244
References
Output from Acceptance Testing