Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_autoscaling_policy Change resource_label required to optional #28597

Closed
tothanhtung0205 opened this issue Dec 28, 2022 · 4 comments · Fixed by #29277
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Milestone

Comments

@tothanhtung0205
Copy link

tothanhtung0205 commented Dec 28, 2022

Description

In aws_autoscaling_policy -> predictive_scaling_configuration -> metric_specification
predefined_load_metric_specification/predefined_metric_pair_specification/predefined_scaling_metric_specification
resource_label is required but it is required only when predefined_metric_type = "ALBTargetGroupRequestCount", so it should be optional. When predefined_metric_type is not equal "ALBTargetGroupRequestCount", we expect to config without resource_label.
In AWS document, it is also no required attribute.

Affected Resource(s) and/or Data Source(s)

  • aws_autoscaling_policy

Potential Terraform Configuration

resource "aws_autoscaling_policy" "example" {
  autoscaling_group_name = "my-test-asg"
  name                   = "foo"
  policy_type            = "PredictiveScaling"
  predictive_scaling_configuration {
    metric_specification {
      target_value = 10
      predefined_load_metric_specification {
        predefined_metric_type = "ASGTotalCPUUtilization"
        # resource_label       = "testLabel" This required only when predefined_metric_type = "ALBTargetGroupRequestCount"
      }
    }
  }
}

References

https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-properties-autoscaling-scalingpolicy-predictivescalingpredefinedmetricpair.html

Would you like to implement a fix?

None

@tothanhtung0205 tothanhtung0205 added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Dec 28, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/autoscaling Issues and PRs that pertain to the autoscaling service. label Dec 28, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 3, 2023
@tmccombs
Copy link
Contributor

tmccombs commented Feb 3, 2023

This seems more like a bug than an enhancement.

@github-actions
Copy link

This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants