-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: eks placement groups - missing config attribute in eks_cluster data source #28924
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEKSClusterDataSource_outpost' PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run=TestAccEKSClusterDataSource_outpost -timeout 180m
=== RUN TestAccEKSClusterDataSource_outpost
=== PAUSE TestAccEKSClusterDataSource_outpost
=== CONT TestAccEKSClusterDataSource_outpost
acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccEKSClusterDataSource_outpost (1.55s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 7.346s
@skyscrapr Thanks for the contribution 🎉 👏. |
Thank you for fixing this bug so fast @skyscrapr , really appreciate this as it will help me on a demo for a large event! 🚀 Thank you @ewbankkit for looking at the PR and merging it so fast, greatly appreciate our community! 🎉 |
This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add missing config attribute in aws_eks_cluster datasource.
Relations
Relates #28112
Closes #28839
References
Output from Acceptance Testing