-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F eks placement groups #28112
F eks placement groups #28112
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…for `id`" This reverts commit bc59b4d.
Acceptance test output: % make testacc TESTARGS='-run=TestAccEKSCluster_basic' PKG=eks ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 3 -run=TestAccEKSCluster_basic -timeout 180m === RUN TestAccEKSCluster_basic === PAUSE TestAccEKSCluster_basic === CONT TestAccEKSCluster_basic --- PASS: TestAccEKSCluster_basic (737.82s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 742.608s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccEKSCluster_\|TestAccEKSClusterDataSource_basic' PKG=eks ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 3 -run=TestAccEKSCluster_\|TestAccEKSClusterDataSource_basic -timeout 360m
=== RUN TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN TestAccEKSCluster_disappears
=== PAUSE TestAccEKSCluster_disappears
=== RUN TestAccEKSCluster_Encryption_create
=== PAUSE TestAccEKSCluster_Encryption_create
=== RUN TestAccEKSCluster_Encryption_update
=== PAUSE TestAccEKSCluster_Encryption_update
=== RUN TestAccEKSCluster_Encryption_versionUpdate
=== PAUSE TestAccEKSCluster_Encryption_versionUpdate
=== RUN TestAccEKSCluster_version
=== PAUSE TestAccEKSCluster_version
=== RUN TestAccEKSCluster_logging
=== PAUSE TestAccEKSCluster_logging
=== RUN TestAccEKSCluster_tags
=== PAUSE TestAccEKSCluster_tags
=== RUN TestAccEKSCluster_VPC_securityGroupIDs
=== PAUSE TestAccEKSCluster_VPC_securityGroupIDs
=== RUN TestAccEKSCluster_VPC_endpointPrivateAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPrivateAccess
=== RUN TestAccEKSCluster_VPC_endpointPublicAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPublicAccess
=== RUN TestAccEKSCluster_VPC_publicAccessCIDRs
=== PAUSE TestAccEKSCluster_VPC_publicAccessCIDRs
=== RUN TestAccEKSCluster_Network_serviceIPv4CIDR
=== PAUSE TestAccEKSCluster_Network_serviceIPv4CIDR
=== RUN TestAccEKSCluster_Network_ipFamily
=== PAUSE TestAccEKSCluster_Network_ipFamily
=== RUN TestAccEKSCluster_Outpost_create
=== PAUSE TestAccEKSCluster_Outpost_create
=== RUN TestAccEKSCluster_Outpost_placement
=== PAUSE TestAccEKSCluster_Outpost_placement
=== CONT TestAccEKSClusterDataSource_basic
=== CONT TestAccEKSCluster_VPC_securityGroupIDs
=== CONT TestAccEKSCluster_Network_serviceIPv4CIDR
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (651.70s)
=== CONT TestAccEKSCluster_VPC_endpointPublicAccess
--- PASS: TestAccEKSClusterDataSource_basic (746.43s)
=== CONT TestAccEKSCluster_VPC_publicAccessCIDRs
--- PASS: TestAccEKSCluster_Network_serviceIPv4CIDR (1403.75s)
=== CONT TestAccEKSCluster_VPC_endpointPrivateAccess
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (915.47s)
=== CONT TestAccEKSCluster_Outpost_create
acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccEKSCluster_Outpost_create (0.56s)
=== CONT TestAccEKSCluster_Outpost_placement
acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccEKSCluster_Outpost_placement (0.18s)
=== CONT TestAccEKSCluster_Network_ipFamily
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1313.24s)
=== CONT TestAccEKSCluster_Encryption_versionUpdate
--- PASS: TestAccEKSCluster_Network_ipFamily (1318.29s)
=== CONT TestAccEKSCluster_tags
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (1662.54s)
=== CONT TestAccEKSCluster_logging
--- PASS: TestAccEKSCluster_Encryption_versionUpdate (1298.25s)
=== CONT TestAccEKSCluster_version
--- PASS: TestAccEKSCluster_tags (615.74s)
=== CONT TestAccEKSCluster_Encryption_create
--- PASS: TestAccEKSCluster_logging (738.96s)
=== CONT TestAccEKSCluster_Encryption_update
--- PASS: TestAccEKSCluster_Encryption_create (614.15s)
=== CONT TestAccEKSCluster_disappears
--- PASS: TestAccEKSCluster_version (1202.48s)
=== CONT TestAccEKSCluster_basic
--- PASS: TestAccEKSCluster_disappears (895.78s)
--- PASS: TestAccEKSCluster_basic (761.02s)
--- PASS: TestAccEKSCluster_Encryption_update (1560.23s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 5370.207s
@skyscrapr @bryantbiggs Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Added support for EKS Control Plane Placement for local Amazon EKS cluster on Outposts
Relations
Closes #27560.
Closes #27572.
References
https://docs.aws.amazon.com/eks/latest/userguide/eks-outposts-capacity-considerations.html
Output from Acceptance Testing