Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F eks placement groups #28112

Merged
merged 17 commits into from
Dec 1, 2022
Merged

F eks placement groups #28112

merged 17 commits into from
Dec 1, 2022

Conversation

skyscrapr
Copy link
Contributor

@skyscrapr skyscrapr commented Dec 1, 2022

Description

Added support for EKS Control Plane Placement for local Amazon EKS cluster on Outposts

Relations

Closes #27560.
Closes #27572.

References

https://docs.aws.amazon.com/eks/latest/userguide/eks-outposts-capacity-considerations.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccEKSCluster_Outpost_create PKG=eks

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 2 -run='TestAccEKSCluster_Outpost_create'  -timeout 180m
=== RUN   TestAccEKSCluster_Outpost_create
=== PAUSE TestAccEKSCluster_Outpost_create
=== CONT  TestAccEKSCluster_Outpost_create
--- PASS: TestAccEKSCluster_Outpost_create (1031.40s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        1035.244s

$ make testacc TESTS=TestAccEKSCluster_Outpost_placement PKG=eks 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 2 -run='TestAccEKSCluster_Outpost_placement'  -timeout 180m
=== RUN   TestAccEKSCluster_Outpost_placement
=== PAUSE TestAccEKSCluster_Outpost_placement
=== CONT  TestAccEKSCluster_Outpost_placement
--- PASS: TestAccEKSCluster_Outpost_placement (1062.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        1066.817s

...

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 1, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 1, 2022
Acceptance test output:

% make testacc TESTARGS='-run=TestAccEKSCluster_basic' PKG=eks ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 3  -run=TestAccEKSCluster_basic -timeout 180m
=== RUN   TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== CONT  TestAccEKSCluster_basic
--- PASS: TestAccEKSCluster_basic (737.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	742.608s
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. and removed size/L Managed by automation to categorize the size of a PR. labels Dec 1, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccEKSCluster_\|TestAccEKSClusterDataSource_basic' PKG=eks ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 3  -run=TestAccEKSCluster_\|TestAccEKSClusterDataSource_basic -timeout 360m
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN   TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN   TestAccEKSCluster_disappears
=== PAUSE TestAccEKSCluster_disappears
=== RUN   TestAccEKSCluster_Encryption_create
=== PAUSE TestAccEKSCluster_Encryption_create
=== RUN   TestAccEKSCluster_Encryption_update
=== PAUSE TestAccEKSCluster_Encryption_update
=== RUN   TestAccEKSCluster_Encryption_versionUpdate
=== PAUSE TestAccEKSCluster_Encryption_versionUpdate
=== RUN   TestAccEKSCluster_version
=== PAUSE TestAccEKSCluster_version
=== RUN   TestAccEKSCluster_logging
=== PAUSE TestAccEKSCluster_logging
=== RUN   TestAccEKSCluster_tags
=== PAUSE TestAccEKSCluster_tags
=== RUN   TestAccEKSCluster_VPC_securityGroupIDs
=== PAUSE TestAccEKSCluster_VPC_securityGroupIDs
=== RUN   TestAccEKSCluster_VPC_endpointPrivateAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPrivateAccess
=== RUN   TestAccEKSCluster_VPC_endpointPublicAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPublicAccess
=== RUN   TestAccEKSCluster_VPC_publicAccessCIDRs
=== PAUSE TestAccEKSCluster_VPC_publicAccessCIDRs
=== RUN   TestAccEKSCluster_Network_serviceIPv4CIDR
=== PAUSE TestAccEKSCluster_Network_serviceIPv4CIDR
=== RUN   TestAccEKSCluster_Network_ipFamily
=== PAUSE TestAccEKSCluster_Network_ipFamily
=== RUN   TestAccEKSCluster_Outpost_create
=== PAUSE TestAccEKSCluster_Outpost_create
=== RUN   TestAccEKSCluster_Outpost_placement
=== PAUSE TestAccEKSCluster_Outpost_placement
=== CONT  TestAccEKSClusterDataSource_basic
=== CONT  TestAccEKSCluster_VPC_securityGroupIDs
=== CONT  TestAccEKSCluster_Network_serviceIPv4CIDR
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (651.70s)
=== CONT  TestAccEKSCluster_VPC_endpointPublicAccess
--- PASS: TestAccEKSClusterDataSource_basic (746.43s)
=== CONT  TestAccEKSCluster_VPC_publicAccessCIDRs
--- PASS: TestAccEKSCluster_Network_serviceIPv4CIDR (1403.75s)
=== CONT  TestAccEKSCluster_VPC_endpointPrivateAccess
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (915.47s)
=== CONT  TestAccEKSCluster_Outpost_create
    acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccEKSCluster_Outpost_create (0.56s)
=== CONT  TestAccEKSCluster_Outpost_placement
    acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccEKSCluster_Outpost_placement (0.18s)
=== CONT  TestAccEKSCluster_Network_ipFamily
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1313.24s)
=== CONT  TestAccEKSCluster_Encryption_versionUpdate
--- PASS: TestAccEKSCluster_Network_ipFamily (1318.29s)
=== CONT  TestAccEKSCluster_tags
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (1662.54s)
=== CONT  TestAccEKSCluster_logging
--- PASS: TestAccEKSCluster_Encryption_versionUpdate (1298.25s)
=== CONT  TestAccEKSCluster_version
--- PASS: TestAccEKSCluster_tags (615.74s)
=== CONT  TestAccEKSCluster_Encryption_create
--- PASS: TestAccEKSCluster_logging (738.96s)
=== CONT  TestAccEKSCluster_Encryption_update
--- PASS: TestAccEKSCluster_Encryption_create (614.15s)
=== CONT  TestAccEKSCluster_disappears
--- PASS: TestAccEKSCluster_version (1202.48s)
=== CONT  TestAccEKSCluster_basic
--- PASS: TestAccEKSCluster_disappears (895.78s)
--- PASS: TestAccEKSCluster_basic (761.02s)
--- PASS: TestAccEKSCluster_Encryption_update (1560.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	5370.207s

@ewbankkit
Copy link
Contributor

@skyscrapr @bryantbiggs Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 40efd3f into hashicorp:main Dec 1, 2022
@github-actions github-actions bot added this to the v4.45.0 milestone Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This functionality has been released in v4.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: EKS cluster ID is not always cluster name
3 participants