[New Resource]: Security Lake

[schuylr]

Description

Looking to add Security Lake as a new Terraform Resource / Data Source so users with IaC requirements in their production environments can effectively start using this service.

Requested Resource(s) and/or Data Source(s)

• aws_security_lake_data_lake
• aws_security_lake_aws_log_source
• aws_security_lake_custom_log_source
• aws_security_lake_subscriber

Potential Terraform Configuration

resource "aws_security_lake_data_lake" "example" {
  configurations {
    us-east-1 {
      encryptionKey                 = "string"
      replicationDestinationRegions = ["us-west-2"]
      replicationRoleArn            = "string"
      retentionSettings = [
        {
          retentionPeriod = 14
          storageClass    = "GLACIER"
        }
      ]
      tagsMap {
        key = "value"
      }
    }
  }

  enableAll               = true
  metaStoreManagerRoleArn = "string"
  regions                 = ["us-east-1"]
}


resource "aws_security_lake_aws_log_source" "example" {
  enableAllDimensions = {
    string = {
      string = ["string"]
    }
  }
  enableSingleDimension = ["string"]
  enableTwoDimensions = {
    string = ["string"]
  }
  inputOrder = ["string"]
}

resource "aws_security_lake_subscriber" "example" {
  accessTypes = ["LAKEFORMATION"]
  accountId   = "1234567890"
  externalId  = "1234567890"
  sourceTypes = [
    {
      awsSourceType    = "string"
      customSourceType = "string"
    }
  ]
  subscriberDescription = "string"
  subscriberName        = "string"
}

References

https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/securitylake
https://docs.aws.amazon.com/security-lake/latest/APIReference/API_CreateDatalake.html
https://docs.aws.amazon.com/security-lake/latest/APIReference/API_CreateSubscriber.html
https://docs.aws.amazon.com/security-lake/latest/APIReference/API_CreateAwsLogSource.html
https://docs.aws.amazon.com/security-lake/latest/APIReference/API_CreateCustomLogSource.html

Would you like to implement a fix?

Yes

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[aristosvo]

I am interested in contributing, but as this would be my first issue on the AWS provider this might take a bit longer.

I have a bit of experience with azurerm though.

[AdamTylerLynch]

I am interested in contributing, but as this would be my first issue on the AWS provider this might take a bit longer.

I have a bit of experience with azurerm though.

@aristosvo AWS published a workshop on contributing to the AWS provider, I would suggest you start there as a learning path.
https://catalog.workshops.aws/contributing-to-the-terraform-provider

[markoskandylis]

I will start working on this resource @aristosvo did you already made any progress? We can always collaborate :)

[aristosvo]

Take it away, didn't have the time in the end. Will watch your MR to learn :)

[luescher-aws]

Happy to help contribute, I am a SME for Amazon Security Lake.

[markoskandylis]

Thats great @luescher-aws please ping me internally to connect @mkandyli

[pfrederiksen]

Also happy to help if you want to connect internally.

[meetreks]

@luescher-aws anyone picked up the log configuration? If not happy to wrap that up, had a look and looks pretty straightforward.

[markoskandylis]

Hi @meetreks i am already working on that @luescher-aws you can work on custom logs if you want to pick something

[meetreks]

@markoskandylis shall i pick create subscriber then?

[markoskandylis]

@meetreks yes that sounds great 🙂

[gramsa49]

I wanted to see if progress is being made on aws log sources. I can pick that up if your work has stalled.

[markoskandylis]

Hi @gramsa49 aws log sources is now merged but you can take custom log sources if you want

[markoskandylis]

Hi i will stat the work for custom log source

[kamalika-majumder]

Anyone working on the securitylake subscriber resources ?

[luescher-aws]

Yes, let me check how far we are. From: Kamalika Majumder ***@***.***> Reply-To: hashicorp/terraform-provider-aws ***@***.***> Date: Monday, February 12, 2024 at 1:20 PM To: hashicorp/terraform-provider-aws ***@***.***> Cc: "Luescher, Marc" ***@***.***>, Mention ***@***.***> Subject: Re: [hashicorp/terraform-provider-aws] [New Resource]: Security Lake (Issue #29376) Anyone working on the securitylake subscriber resources ? — Reply to this email directly, view it on GitHub<#29376 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A7JB5GJMX6ODCCSWY3C4TL3YTJMNVAVCNFSM6AAAAAAU2S2JQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGI4TCNJRGQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[markoskandylis]

Hi @kamalika-majumder currently i am working on it

[kamalika-majumder]

Oh great. @markoskandylis Any idea which release its going to be added next ?

[markoskandylis]

@kamalika-majumder i will aim for the 29th release hopefully a bit faster if posible

[github-actions]

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[kclinden]

Are there any plans to add a resource for managing Org configurations via following:

• Action - CreateDataLakeOrganizationConfiguration
• Action - GetDataLakeOrganizationConfiguration
• Action - DeleteDataLakeOrganizationConfiguration
• DataType - DataLakeAutoEnableNewAccountConfiguration

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.