Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Service]: VPC Lattice #30380

Closed
11 tasks done
bryantbiggs opened this issue Mar 31, 2023 · 9 comments
Closed
11 tasks done

[New Service]: VPC Lattice #30380

bryantbiggs opened this issue Mar 31, 2023 · 9 comments
Assignees
Labels
service/vpclattice Issues and PRs that pertain to the vpclattice service.

Comments

@bryantbiggs
Copy link
Contributor

bryantbiggs commented Mar 31, 2023

Description

Support for recently announced VPC Lattice

Requested Resource(s) and/or Data Source(s)

Potential Terraform Configuration

TBD

References

Would you like to implement a fix?

None

@bryantbiggs bryantbiggs added the needs-triage Waiting for first response or review from a maintainer. label Mar 31, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/vpc Issues and PRs that pertain to the vpc service. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 31, 2023
@bryantbiggs bryantbiggs changed the title [New]: VPC Lattice [New Service]: VPC Lattice Mar 31, 2023
@mattburgess
Copy link
Collaborator

I'll take a look at what's required to implement this service. I'll likely create separate tickets for each resource so that progress is more easily tracked.

@mattburgess
Copy link
Collaborator

Potential order in which the various resources should be tackled based on their dependencies and workflow enablement:

  • aws_vpclattice_service
  • aws_vpclattice_service_network
  • aws_vpclattice_service_network_service_association
    • Depends on aws_vpclattice_service
    • Depends on aws_vpclattice_service_network
  • aws_vpclattice_service_network_vpc_association
    • Depends on aws_vpclattice_service_network
  • aws_vpclattice_listener
    • Depends on aws_vpclattice_service
  • aws_vpclattice_target_group
  • aws_vpclattice_rule
    • Depends on aws_vpclattice_listener
    • Depends on aws_vpclattice_target_group
  • aws_vpclattice_access_log_subscription
    • Depends on aws_vpclattice_service_network
    • Depends on aws_vpclattice_service

@mattburgess mattburgess mentioned this issue Apr 3, 2023
@meetreks
Copy link
Contributor

meetreks commented Apr 3, 2023

@mattburgess @bryantbiggs why have you closed my ticket?

@mattburgess
Copy link
Collaborator

It looked as if it was a duplicate of this one. Is that incorrect? If not, then what does your ticket cover that this one doesn't?

@bryantbiggs
Copy link
Contributor Author

bryantbiggs commented Apr 14, 2023

@ewbankkit I believe we need some additional resources for the following - are the proposed names correct or should they be named something different?

  1. aws_vpclattice_auth_policy_attachment
  2. aws_vpclattice_resource_policy_attachment
  3. aws_vpclattice_register_targets -> aws_vpclattice_registered_targets?

@ewbankkit
Copy link
Contributor

I suggest

  • aws_vpclattice_auth_policy
  • aws_vpclattice_resource_policy
  • aws_vpclattice_target_group_attachment -- matches aws_alb_target_group_attachment

@bryantbiggs
Copy link
Contributor Author

great work all - really appreciate your efforts, thank you!

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/vpclattice Issues and PRs that pertain to the vpclattice service.
Projects
None yet
Development

No branches or pull requests

4 participants