-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource]: aws_vpclattice_target_group #30602
[New Resource]: aws_vpclattice_target_group #30602
Conversation
…kandylis/terraform-provider-aws into f-vpclattice-resource-targetgroup
Community NoteVoting for Prioritization
For Submitters
|
@ewbankkit can you help with this PR approval please? |
Dear @ewbankkit thanks for checking. We will fix the PR issues and check in the code. |
…t items at the same level [Expected: 0; Actual: 1]'.
@meetreks Don't worry; I am actively working on this. |
…egory: 'VPC Lattice') doesn't match file name prefix, expecting VPC Lattice".
…d: 4; Actual: 2]'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccVPCLatticeTargetGroup_' PKG=vpclattice ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 3 -run=TestAccVPCLatticeTargetGroup_ -timeout 180m
=== RUN TestAccVPCLatticeTargetGroup_basic
=== PAUSE TestAccVPCLatticeTargetGroup_basic
=== RUN TestAccVPCLatticeTargetGroup_disappears
=== PAUSE TestAccVPCLatticeTargetGroup_disappears
=== RUN TestAccVPCLatticeTargetGroup_tags
=== PAUSE TestAccVPCLatticeTargetGroup_tags
=== RUN TestAccVPCLatticeTargetGroup_lambda
=== PAUSE TestAccVPCLatticeTargetGroup_lambda
=== RUN TestAccVPCLatticeTargetGroup_ip
=== PAUSE TestAccVPCLatticeTargetGroup_ip
=== RUN TestAccVPCLatticeTargetGroup_alb
=== PAUSE TestAccVPCLatticeTargetGroup_alb
=== CONT TestAccVPCLatticeTargetGroup_basic
=== CONT TestAccVPCLatticeTargetGroup_lambda
=== CONT TestAccVPCLatticeTargetGroup_tags
--- PASS: TestAccVPCLatticeTargetGroup_lambda (21.84s)
=== CONT TestAccVPCLatticeTargetGroup_disappears
--- PASS: TestAccVPCLatticeTargetGroup_tags (47.75s)
=== CONT TestAccVPCLatticeTargetGroup_alb
--- PASS: TestAccVPCLatticeTargetGroup_basic (80.47s)
=== CONT TestAccVPCLatticeTargetGroup_ip
--- PASS: TestAccVPCLatticeTargetGroup_disappears (67.14s)
--- PASS: TestAccVPCLatticeTargetGroup_alb (70.92s)
--- PASS: TestAccVPCLatticeTargetGroup_ip (73.39s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 159.392s
@markoskandylis Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This pull request will cater for a new resource in the VPC Lattice family - Target Group. For more information kindly refer to this page for details - https://docs.aws.amazon.com/vpc-lattice/latest/ug/target-groups.html
Relations
Closes #30455.
Relates #30380.
References
The API Reference can be found here - https://docs.aws.amazon.com/vpc-lattice/latest/APIReference/API_CreateTargetGroup.html
Output from Acceptance Testing