Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: aws_vpclattice_target_group #30602

Merged

Conversation

markoskandylis
Copy link
Contributor

@markoskandylis markoskandylis commented Apr 10, 2023

Description

This pull request will cater for a new resource in the VPC Lattice family - Target Group. For more information kindly refer to this page for details - https://docs.aws.amazon.com/vpc-lattice/latest/ug/target-groups.html

Relations

Closes #30455.
Relates #30380.

References

The API Reference can be found here - https://docs.aws.amazon.com/vpc-lattice/latest/APIReference/API_CreateTargetGroup.html

Output from Acceptance Testing

$make testacc PKG=vpclattice TESTS=TestAccVPCLatticeTargetGroup_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 20 -run='TestAccVPCLatticeTargetGroup_'  -timeout 180m
=== RUN   TestAccVPCLatticeTargetGroup_basic
=== PAUSE TestAccVPCLatticeTargetGroup_basic
=== RUN   TestAccVPCLatticeTargetGroup_full
=== PAUSE TestAccVPCLatticeTargetGroup_full
=== RUN   TestAccVPCLatticeTargetGroup_disappears
=== PAUSE TestAccVPCLatticeTargetGroup_disappears
=== RUN   TestAccVPCLatticeTargetGroup_tags
=== PAUSE TestAccVPCLatticeTargetGroup_tags
=== CONT  TestAccVPCLatticeTargetGroup_basic
=== CONT  TestAccVPCLatticeTargetGroup_full
=== CONT  TestAccVPCLatticeTargetGroup_tags
=== CONT  TestAccVPCLatticeTargetGroup_disappears
--- PASS: TestAccVPCLatticeTargetGroup_disappears (13.31s)
--- PASS: TestAccVPCLatticeTargetGroup_tags (72.41s)
--- PASS: TestAccVPCLatticeTargetGroup_basic (78.44s)
--- PASS: TestAccVPCLatticeTargetGroup_full (270.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 272.760s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/vpclattice Issues and PRs that pertain to the vpclattice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 10, 2023
@markoskandylis markoskandylis changed the title F vpclattice resource targetgroup [New Resource]: aws_vpclattice_target_group #30455 Apr 10, 2023
@markoskandylis markoskandylis changed the title [New Resource]: aws_vpclattice_target_group #30455 [New Resource]: aws_vpclattice_target_group Apr 10, 2023
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 10, 2023
@meetreks
Copy link
Contributor

@ewbankkit can you help with this PR approval please?

@ewbankkit ewbankkit added the partner Contribution from a partner. label Apr 11, 2023
@meetreks
Copy link
Contributor

Dear @ewbankkit thanks for checking. We will fix the PR issues and check in the code.

@ewbankkit
Copy link
Contributor

@meetreks Don't worry; I am actively working on this.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCLatticeTargetGroup_' PKG=vpclattice ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 3  -run=TestAccVPCLatticeTargetGroup_ -timeout 180m
=== RUN   TestAccVPCLatticeTargetGroup_basic
=== PAUSE TestAccVPCLatticeTargetGroup_basic
=== RUN   TestAccVPCLatticeTargetGroup_disappears
=== PAUSE TestAccVPCLatticeTargetGroup_disappears
=== RUN   TestAccVPCLatticeTargetGroup_tags
=== PAUSE TestAccVPCLatticeTargetGroup_tags
=== RUN   TestAccVPCLatticeTargetGroup_lambda
=== PAUSE TestAccVPCLatticeTargetGroup_lambda
=== RUN   TestAccVPCLatticeTargetGroup_ip
=== PAUSE TestAccVPCLatticeTargetGroup_ip
=== RUN   TestAccVPCLatticeTargetGroup_alb
=== PAUSE TestAccVPCLatticeTargetGroup_alb
=== CONT  TestAccVPCLatticeTargetGroup_basic
=== CONT  TestAccVPCLatticeTargetGroup_lambda
=== CONT  TestAccVPCLatticeTargetGroup_tags
--- PASS: TestAccVPCLatticeTargetGroup_lambda (21.84s)
=== CONT  TestAccVPCLatticeTargetGroup_disappears
--- PASS: TestAccVPCLatticeTargetGroup_tags (47.75s)
=== CONT  TestAccVPCLatticeTargetGroup_alb
--- PASS: TestAccVPCLatticeTargetGroup_basic (80.47s)
=== CONT  TestAccVPCLatticeTargetGroup_ip
--- PASS: TestAccVPCLatticeTargetGroup_disappears (67.14s)
--- PASS: TestAccVPCLatticeTargetGroup_alb (70.92s)
--- PASS: TestAccVPCLatticeTargetGroup_ip (73.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	159.392s

@ewbankkit
Copy link
Contributor

@markoskandylis Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e6ea81c into hashicorp:main Apr 11, 2023
@github-actions github-actions bot added this to the v4.63.0 milestone Apr 11, 2023
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/vpclattice Issues and PRs that pertain to the vpclattice service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_vpclattice_target_group
3 participants