Fixed WAFv2 ATP response inspection parameters

[rasekoli]

Description

Fixes three response_inspection ATP parameters (body_contains, header, json).

Relations

Closes #31106

References

Output from Acceptance Testing

$ make testacc PKG=wafv2 TESTS=TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ATPRuleSet
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/wafv2/... -v -count 1 -parallel 20 -run='TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ATPRuleSet'  -timeout 180m
=== RUN   TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ATPRuleSet
=== PAUSE TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ATPRuleSet
=== CONT  TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ATPRuleSet
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ATPRuleSet (50.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/wafv2      50.196s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @rasekoli 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[rasekoli]

Were you able to add an Account Takeover Protection rule to a WAFv2 Web ACL using success_strings instead of succeed_strings parameter? In #31106 issue I pasted the errors I get in this case, and I was able to add an ATP rule using succeed_strings successfully.

[gdavison]

Yes, these lines in the flatten... functions were the problem. They should have been success_... instead of succeed_... to match the names of the parameters returned by AWS

[gdavison]

Thanks for the PR, @rasekoli. I've made some adjustments to bring the names in line with the AWS API parameters and added an acceptance test.

Acceptance test results in Commercial partition

--- PASS: TestAccWAFV2WebACL_CloudFrontScope (80.15s)
--- PASS: TestAccWAFV2WebACL_tokenDomains (83.79s)
--- PASS: TestAccWAFV2WebACL_Operators_maxNested (102.65s)
--- PASS: TestAccWAFV2WebACL_RateBased_maxNested (116.40s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_BotControl (133.09s)
--- PASS: TestAccWAFV2WebACL_IPSetReference_basic (141.87s)
--- PASS: TestAccWAFV2WebACL_basic (157.40s)
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_manageShieldMitigationRule (161.45s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ATPRuleSet (168.38s)
--- PASS: TestAccWAFV2WebACL_LabelMatchStatement (169.94s)
--- PASS: TestAccWAFV2WebACL_disappears (89.73s)
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_shieldMitigation (182.23s)
--- PASS: TestAccWAFV2WebACL_RuleLabels (184.67s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig (200.08s)
--- PASS: TestAccWAFV2WebACL_GeoMatch_forwardedIP (204.92s)
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_basic (228.16s)
--- PASS: TestAccWAFV2WebACL_minimal (90.86s)
--- PASS: TestAccWAFV2WebACL_RateBased_forwardedIP (233.87s)
--- PASS: TestAccWAFV2WebACL_Custom_response (246.61s)
--- PASS: TestAccWAFV2WebACL_Update_nameForceNew (159.62s)
--- PASS: TestAccWAFV2WebACL_tags (271.01s)
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_basic (151.19s)
--- PASS: TestAccWAFV2WebACL_GeoMatch_basic (136.35s)
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_body (135.79s)
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_jsonBody (129.79s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion (130.69s)
--- PASS: TestAccWAFV2WebACL_RateBased_basic (120.50s)
--- PASS: TestAccWAFV2WebACL_Update_rule (130.51s)
--- PASS: TestAccWAFV2WebACL_IPSetReference_forwardedIP (306.44s)
--- PASS: TestAccWAFV2WebACL_Custom_requestHandling (306.45s)
--- PASS: TestAccWAFV2WebACL_Update_ruleProperties (196.50s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_basic (236.62s)

Acceptance test results in Gov Cloud partition

--- SKIP: TestAccWAFV2WebACL_CloudFrontScope (112.60s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_BotControl (247.28s)
--- PASS: TestAccWAFV2WebACL_minimal (254.12s)
--- PASS: TestAccWAFV2WebACL_basic (284.12s)
--- PASS: TestAccWAFV2WebACL_tokenDomains (292.39s)
--- PASS: TestAccWAFV2WebACL_Operators_maxNested (306.42s)
--- PASS: TestAccWAFV2WebACL_RateBased_maxNested (323.49s)
--- SKIP: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig_ATPRuleSet (104.86s)
--- SKIP: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig (99.93s)
--- PASS: TestAccWAFV2WebACL_disappears (207.76s)
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_manageShieldMitigationRule (459.68s)
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_jsonBody (466.34s)
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_shieldMitigation (478.97s)
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_basic (482.16s)
--- PASS: TestAccWAFV2WebACL_RateBased_basic (483.12s)
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_body (486.90s)
--- PASS: TestAccWAFV2WebACL_GeoMatch_forwardedIP (488.67s)
--- PASS: TestAccWAFV2WebACL_RateBased_forwardedIP (490.09s)
--- PASS: TestAccWAFV2WebACL_GeoMatch_basic (490.15s)
--- PASS: TestAccWAFV2WebACL_IPSetReference_basic (205.26s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion (400.65s)
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_basic (532.92s)
--- PASS: TestAccWAFV2WebACL_tags (549.23s)
--- PASS: TestAccWAFV2WebACL_Custom_response (561.36s)
--- PASS: TestAccWAFV2WebACL_RuleLabels (237.76s)
--- PASS: TestAccWAFV2WebACL_Update_nameForceNew (166.27s)
--- PASS: TestAccWAFV2WebACL_Custom_requestHandling (629.06s)
--- PASS: TestAccWAFV2WebACL_LabelMatchStatement (175.59s)
--- PASS: TestAccWAFV2WebACL_Update_rule (175.81s)
--- PASS: TestAccWAFV2WebACL_Update_ruleProperties (284.20s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_basic (380.58s)
--- PASS: TestAccWAFV2WebACL_IPSetReference_forwardedIP (355.11s)

[github-actions]

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.