Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_redshiftserverless_workgroup: config_parameter fixes #31747

Merged
merged 9 commits into from
Jun 2, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 2, 2023

Description

Fixes to the aws_redshiftserverless_workgroup's config_parameter attribute and resource updates in general.

Relations

Closes #27973.
Closes #31451.
Closes #28255.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRedshiftServerlessWorkgroup_' PKG=redshiftserverless ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 3  -run=TestAccRedshiftServerlessWorkgroup_ -timeout 180m
=== RUN   TestAccRedshiftServerlessWorkgroup_basic
=== PAUSE TestAccRedshiftServerlessWorkgroup_basic
=== RUN   TestAccRedshiftServerlessWorkgroup_baseCapacityAndPubliclyAccessible
=== PAUSE TestAccRedshiftServerlessWorkgroup_baseCapacityAndPubliclyAccessible
=== RUN   TestAccRedshiftServerlessWorkgroup_configParameters
=== PAUSE TestAccRedshiftServerlessWorkgroup_configParameters
=== RUN   TestAccRedshiftServerlessWorkgroup_tags
=== PAUSE TestAccRedshiftServerlessWorkgroup_tags
=== RUN   TestAccRedshiftServerlessWorkgroup_disappears
=== PAUSE TestAccRedshiftServerlessWorkgroup_disappears
=== CONT  TestAccRedshiftServerlessWorkgroup_basic
=== CONT  TestAccRedshiftServerlessWorkgroup_tags
=== CONT  TestAccRedshiftServerlessWorkgroup_configParameters
--- PASS: TestAccRedshiftServerlessWorkgroup_tags (456.56s)
=== CONT  TestAccRedshiftServerlessWorkgroup_disappears
--- PASS: TestAccRedshiftServerlessWorkgroup_basic (505.40s)
=== CONT  TestAccRedshiftServerlessWorkgroup_baseCapacityAndPubliclyAccessible
=== CONT  TestAccRedshiftServerlessWorkgroup_configParameters
    testing_new.go:88: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: waiting for Redshift Serverless Namespace (tf-acc-test-6522553958189673502) delete: timeout while waiting for resource to be gone (last state: 'DELETING', timeout: 10m0s)
        
--- FAIL: TestAccRedshiftServerlessWorkgroup_configParameters (899.41s)
--- PASS: TestAccRedshiftServerlessWorkgroup_disappears (540.23s)
--- PASS: TestAccRedshiftServerlessWorkgroup_baseCapacityAndPubliclyAccessible (678.70s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless	1189.290s
FAIL
make: *** [testacc] Error 1

Failure is unrelated to this change.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 2, 2023
@ewbankkit ewbankkit changed the title r/aws_redshiftserverless_workgroup: config_parameters fixes r/aws_redshiftserverless_workgroup: config_parameter fixes Jun 2, 2023
@ewbankkit ewbankkit merged commit a79e83a into main Jun 2, 2023
@ewbankkit ewbankkit deleted the b-aws_redshiftserverless_workgroup.config_parameter branch June 2, 2023 20:28
@github-actions github-actions bot added this to the v5.2.0 milestone Jun 2, 2023
github-actions bot pushed a commit that referenced this pull request Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
1 participant