Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wrong argument mapping #32785

Closed
vstepanyuk opened this issue Aug 1, 2023 · 4 comments · Fixed by #32793
Closed

[Bug]: Wrong argument mapping #32785

vstepanyuk opened this issue Aug 1, 2023 · 4 comments · Fixed by #32793
Assignees
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ecs Issues and PRs that pertain to the ecs service.
Milestone

Comments

@vstepanyuk
Copy link

vstepanyuk commented Aug 1, 2023

Terraform Core Version

1.0.0

AWS Provider Version

5.10.0

Affected Resource(s)

  • aws_ecs

Expected Behavior

Expected mapping memory_reservation to MemoryReservation options instead of overriding Memory option.
https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/ecs/task_execution_data_source.go#L436

Actual Behavior

memory_reservation mapped to Memory

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

Steps to Reproduce

data "aws_ecs_task_execution" "before" {
  cluster         = "cluster"
  task_definition = ...
  desired_count   = 1
  launch_type     = "FARGATE"

  overrides {
    container_overrides {
      name    = "container"

      cpu    = 256
      memory = 512
    }

    cpu    = 256
    memory = 512
  }
}

Debug Output

"overrides": {
                "containerOverrides": [
                    {
                        "name": "container",
                        "cpu": 256,
                        "memory": 0
                    }
                ],
                "cpu": "256",
                "inferenceAcceleratorOverrides": [],
                "executionRoleArn": "",
                "memory": "512",
                "taskRoleArn": ""
            }
...

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

@vstepanyuk vstepanyuk added the bug Addresses a defect in current functionality. label Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. needs-triage Waiting for first response or review from a maintainer. labels Aug 1, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 1, 2023
@justinretzolk justinretzolk self-assigned this Aug 1, 2023
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 1, 2023
@justinretzolk
Copy link
Member

Hey @vstepanyuk 👋 Thank you for taking the time to raise this! I've opened a pull request to correct this.

@github-actions github-actions bot added this to the v5.11.0 milestone Aug 1, 2023
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
2 participants