-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct aws_ecs_task_execution
data source container_overrides
expander
#32793
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc TESTS=TestAccECSTaskExecutionDataSource PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskExecutionDataSource' -timeout 180m
--- PASS: TestAccECSTaskExecutionDataSource_tags (292.26s)
--- PASS: TestAccECSTaskExecutionDataSource_basic (294.95s)
--- PASS: TestAccECSTaskExecutionDataSource_overrides (294.95s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 298.007s
This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR corrects an issue where the
container_overrides
expander of theaws_ecs_task_execution
data source incorrectly set the value ofmemory_reservation
to the value ofmemory
.Relations
Closes #32785
References
ecs.ContainerOverride
Output from Acceptance Testing