Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org unit data source #33408

Merged
merged 21 commits into from
Sep 19, 2023
Merged

Add org unit data source #33408

merged 21 commits into from
Sep 19, 2023

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Sep 11, 2023

Description

Adds an organizational_unit data lookup for a single entity.

Relations

Closes #22909

References

Output from Acceptance Testing

% TF_ACC=1 make testacc TESTS=TestAccOrganizationalUnitDataSource_ PKG=organizations
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/organizations/... -v -count 1 -parallel 20 -run='TestAccOrganizationalUnitDataSource_'  -timeout 180m
=== RUN   TestAccOrganizationalUnitDataSource_basic
--- PASS: TestAccOrganizationalUnitDataSource_basic (25.26s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/organizations      27.338s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/organizations Issues and PRs that pertain to the organizations service. generators Relates to code generators. labels Sep 11, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 11, 2023
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 11, 2023
@danquack danquack marked this pull request as ready for review September 15, 2023 18:48
% make testacc TESTARGS='-run=TestAccOrganizations_serial/OrganizationalUnit' PKG=organizations
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/organizations/... -v -count 1 -parallel 20  -run=TestAccOrganizations_serial/OrganizationalUnit -timeout 180m
=== RUN   TestAccOrganizations_serial
=== PAUSE TestAccOrganizations_serial
=== CONT  TestAccOrganizations_serial
=== RUN   TestAccOrganizations_serial/OrganizationalUnit
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/ChildAccountsDataSource_basic
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/DescendantAccountsDataSource_basic
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/PluralDataSource_basic
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/basic
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/disappears
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/update
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/tags
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/DataSource_basic
--- PASS: TestAccOrganizations_serial (253.25s)
    --- PASS: TestAccOrganizations_serial/OrganizationalUnit (253.25s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/ChildAccountsDataSource_basic (19.81s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/DescendantAccountsDataSource_basic (31.30s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/PluralDataSource_basic (23.93s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/basic (27.58s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/disappears (21.07s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/update (43.95s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/tags (61.44s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/DataSource_basic (24.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/organizations	258.977s
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOrganizations_serial/OrganizationalUnit' PKG=organizations
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/organizations/... -v -count 1 -parallel 20  -run=TestAccOrganizations_serial/OrganizationalUnit -timeout 180m
=== RUN   TestAccOrganizations_serial
=== PAUSE TestAccOrganizations_serial
=== CONT  TestAccOrganizations_serial
=== RUN   TestAccOrganizations_serial/OrganizationalUnit
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/ChildAccountsDataSource_basic
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/DescendantAccountsDataSource_basic
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/PluralDataSource_basic
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/basic
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/disappears
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/update
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/tags
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/DataSource_basic
--- PASS: TestAccOrganizations_serial (253.25s)
    --- PASS: TestAccOrganizations_serial/OrganizationalUnit (253.25s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/ChildAccountsDataSource_basic (19.81s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/DescendantAccountsDataSource_basic (31.30s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/PluralDataSource_basic (23.93s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/basic (27.58s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/disappears (21.07s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/update (43.95s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/tags (61.44s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/DataSource_basic (24.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/organizations	258.977s

@ewbankkit
Copy link
Contributor

@danquack Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 701f091 into hashicorp:main Sep 19, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.18.0 milestone Sep 19, 2023
@github-actions
Copy link

This functionality has been released in v5.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
@danquack danquack deleted the 22909 branch October 23, 2023 02:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/organizations Issues and PRs that pertain to the organizations service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request/New Data Source organizations_organizational_unit
3 participants