Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_dms_replication_task: allow removal of replication_task_settings #33456

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Sep 13, 2023

Description

When replication_task_settings attribute is removed the following error occurs:

Error: updating DMS Replication Task (test-dms-replication-task-tf): InvalidParameterValueException: Invalid task settings json 
│       status code: 400, request id: ab973d14-ad51-430e-9776-9cef4dce0593
│ 
│   with aws_dms_replication_task.test,
│   on main.tf line 82, in resource "aws_dms_replication_task" "test":
│   82: resource "aws_dms_replication_task" "test" {

Relations

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccDMSReplicationTask_basic' PKG=dms 

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSReplicationTask_basic -timeout 180m
--- PASS: TestAccDMSReplicationTask_basic (1033.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	1036.326s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/dms Issues and PRs that pertain to the dms service. labels Sep 13, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2023
@johnsonaj johnsonaj added bug Addresses a defect in current functionality. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 13, 2023
@johnsonaj johnsonaj merged commit d03c857 into main Sep 13, 2023
31 checks passed
@johnsonaj johnsonaj deleted the b-aws_dms_replication_task_task_settings branch September 13, 2023 22:04
@github-actions github-actions bot added this to the v5.17.0 milestone Sep 13, 2023
github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
@github-actions
Copy link

This functionality has been released in v5.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/dms Issues and PRs that pertain to the dms service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant