Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_dms_replication_task: allow removal of replication_task_settings #33456

Merged
merged 3 commits into from
Sep 13, 2023
Merged

aws_dms_replication_task: allow removal of replication_task_settings #33456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecb4ff9
aws_dms_replication_task: allow removal of replication_task_settings
johnsonaj Sep 13, 2023
34c5ab7
aws_dms_replication_task: allow removal of replication_task_settings
johnsonaj Sep 13, 2023
99a9b31
add CHANGELOG entry
johnsonaj Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/33456.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_dms_replication_task: Fix error when `replication_task_settings` is `nil`
```
6 changes: 5 additions & 1 deletion internal/service/dms/replication_task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,11 @@ func resourceReplicationTaskUpdate(ctx context.Context, d *schema.ResourceData,
}

if d.HasChange("replication_task_settings") {
input.ReplicationTaskSettings = aws.String(d.Get("replication_task_settings").(string))
if v, ok := d.Get("replication_task_settings").(string); ok && v != "" {
input.ReplicationTaskSettings = aws.String(v)
} else {
input.ReplicationTaskSettings = nil
}
}

status := d.Get("status").(string)
Expand Down
Loading