Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_appflow_connector_profile: add salesforce jwt_token and oauth2_grant_type arguments #34248

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Nov 3, 2023

Description

Adds support for JWT related arguments in the salesforce configuration block.

Relations

Closes #31306

References

Output from Acceptance Testing

% make testacc PKG=appflow TESTS=TestAccAppFlowConnectorProfile_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20 -run='TestAccAppFlowConnectorProfile_'  -timeout 360m

--- PASS: TestAccAppFlowConnectorProfile_basic (574.54s)
--- PASS: TestAccAppFlowConnectorProfile_disappears (588.36s)
--- PASS: TestAccAppFlowConnectorProfile_update (764.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appflow    768.024s

Copy link

github-actions bot commented Nov 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/appflow Issues and PRs that pertain to the appflow service. labels Nov 3, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 3, 2023
@jar-b jar-b force-pushed the f-appflow-salesforce-auth branch from 289b7bf to 9568a21 Compare November 3, 2023 18:01
@jar-b jar-b merged commit 3e97ed5 into main Nov 3, 2023
40 checks passed
@jar-b jar-b deleted the f-appflow-salesforce-auth branch November 3, 2023 18:30
@github-actions github-actions bot added this to the v5.25.0 milestone Nov 3, 2023
github-actions bot pushed a commit that referenced this pull request Nov 3, 2023
Copy link

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/appflow Issues and PRs that pertain to the appflow service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Appflow JWT support for Salesforce authentication
1 participant